Merge pull request diffblue#457 from diffblue/cleanup/remove-noexcept

Remove noexcept from methods that allocate heap memory

Author: NathanJPhillips

src/pointer-analysis/local_value_set_analysis.h

@@ -51,7 +51,7 @@ class lvsaa_single_external_set_summaryt : public summaryt
   lvsaa_single_external_set_summaryt &
   operator=(lvsaa_single_external_set_summaryt &&) = default;
 
-  std::string kind() const noexcept override
+  std::string kind() const override
   {
     return "lvsaa";
   }

src/summaries/summary.h

@@ -39,12 +39,15 @@ class summaryt
    summaries. For example, it can be a unique name of an analysis which has
    computed them.
   \*******************************************************************/
-  virtual std::string kind() const noexcept=0;
+  virtual std::string kind() const = 0;
 
   /*******************************************************************\
    A textual human-readable description of the summaries.
   \*******************************************************************/
-  virtual std::string description() const noexcept { return std::string(); }
+  virtual std::string description() const
+  {
+    return std::string();
+  }
 };
 
 #endif

src/taint-analysis/taint_summary.cpp

@@ -328,12 +328,12 @@ static void populate_formals_to_actuals(
 ///
 ////////////////////////////////////////////////////////////////////////////////
 
-std::string taint_summaryt::kind() const noexcept
+std::string taint_summaryt::kind() const
 {
   return "cbmc://src/taint-analysis/taint_summary";
 }
 
-std::string taint_summaryt::description() const noexcept
+std::string taint_summaryt::description() const
 {
   return "Function summary of taint analysis of java web applications.";
 }

src/taint-analysis/taint_summary.h

@@ -137,8 +137,8 @@ class taint_summaryt:public summaryt
   taint_summaryt &operator=(const taint_summaryt &) = delete;
   taint_summaryt &operator=(taint_summaryt &&) = default;
 
-  std::string kind() const noexcept override;
-  std::string description() const noexcept override;
+  std::string kind() const override;
+  std::string description() const override;
 
   const taint_summary_inputt& get_input() const noexcept
   {