Updates requested in the review.

Author: marek-trtik

driver/analyser.py

@@ -228,12 +228,14 @@ def run_search_for_error_traces(
         loc_info_file = os.path.abspath(os.path.join(results_dir, "..", "program_slicing", "map_from_functions_to_rule_application_sites.json"))
         loc_descriptions = generate_location_descriptions(loc_info_file)
         with open(os.path.join(results_dir, "location_descriptions.json"), "w") as descriptions_file:
-            descriptions_file.write(json.dumps(loc_descriptions, sort_keys=True, indent=4))
+            json.dump(loc_descriptions, descriptions_file, sort_keys=True, indent=4)
         for error_trace in traces_list:
             if error_trace["file"] in loc_descriptions:
                 file_description = loc_descriptions[error_trace["file"]]
                 if error_trace["line"] in file_description:
                     file_line_description = file_description[error_trace["line"]]
+                    # When using CSVSA some functions get suffixed with "$spec_".
+                    # So, instead of equality check we use "startswith" check.
                     if file_line_description["function"].startswith(error_trace["function"]):
                         error_trace["message"] = file_line_description["message"]
                     else:

driver/presentation.py

@@ -392,7 +392,7 @@ def make_reduction_string(orig_value, reduced_value, add_percentage=True):
     ofile.write("</table>\n")
 
 
-def build_HTML_interface_to_group_of_error_traces(traces,tool_name,tgt_file,tgt_line,message,ofile):
+def build_HTML_interface_to_group_of_error_traces(traces, tool_name, tgt_file, tgt_line, message, ofile):
     ofile.write(get_html_prefix("Error traces " + tool_name))
 
     ofile.write("<h1>Error traces found by " + tool_name + "</h1>\n")