Skip to content

Commit fa4c7b7

Browse files
marcin-wosineklgalfaso
authored andcommitted
feat($time): create time service
Add simple $time service to allow easier mocking dates in applications. Closes angular#10402 Closes angular#10525
1 parent 652b83e commit fa4c7b7

File tree

4 files changed

+73
-0
lines changed

4 files changed

+73
-0
lines changed

angularFiles.js

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ var angularFiles = {
3838
'src/ng/sniffer.js',
3939
'src/ng/templateRequest.js',
4040
'src/ng/testability.js',
41+
'src/ng/date.js',
4142
'src/ng/timeout.js',
4243
'src/ng/urlUtils.js',
4344
'src/ng/window.js',

src/AngularPublic.js

+2
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
$TemplateCacheProvider,
8787
$TemplateRequestProvider,
8888
$$TestabilityProvider,
89+
$TimeProvider,
8990
$TimeoutProvider,
9091
$$RAFProvider,
9192
$WindowProvider,
@@ -244,6 +245,7 @@ function publishExternalAPI(angular) {
244245
$templateCache: $TemplateCacheProvider,
245246
$templateRequest: $TemplateRequestProvider,
246247
$$testability: $$TestabilityProvider,
248+
$date: $DateProvider,
247249
$timeout: $TimeoutProvider,
248250
$window: $WindowProvider,
249251
$$rAF: $$RAFProvider,

src/ng/date.js

+45
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
'use strict';
2+
3+
/**
4+
* @ngdoc service
5+
* @name $date
6+
* @requires $window
7+
*
8+
* @description
9+
* Simple service for accessing date.
10+
*
11+
* The main purpose of this service is to simplify mocking date in tests.
12+
*
13+
* @example
14+
<example module="dateExample">
15+
<file name="script.js">
16+
angular.module('dateExample', [])
17+
.controller('TimeController', ['$scope', '$date', function($scope, $date) {
18+
$scope.now = $date.now();
19+
}]);
20+
</file>
21+
<file name="index.html">
22+
<div ng-controller="TimeController">
23+
<p>Time when the page was created: {{now | date}}</p>
24+
</div>
25+
</file>
26+
</example>
27+
*/
28+
function $DateProvider() {
29+
var self = this;
30+
31+
this.$get = ['$window', function($window) {
32+
return {
33+
/**
34+
* @ngdoc method
35+
* @name $date#now
36+
*
37+
* @description
38+
* Return Date object representing current date
39+
*/
40+
now: function () {
41+
return $window.Date();
42+
}
43+
};
44+
}];
45+
}

test/ng/dateSpec.js

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/* global $TimeProvider: false */
2+
'use strict';
3+
4+
describe('$date', function() {
5+
var $window;
6+
7+
beforeEach(module(function($provide) {
8+
$window = {};
9+
10+
$provide.value('$window', $window);
11+
}));
12+
13+
it('should return Date.new() when $date.now() is called', inject(
14+
function() {
15+
$window.Date = function() {
16+
return Date(1418998923940);
17+
};
18+
},
19+
function($date) {
20+
var date = $date.now();
21+
expect(date).toEqual(Date(1418998923940));
22+
}
23+
));
24+
25+
});

0 commit comments

Comments
 (0)