feat($compile): throw error when directive name or factory fn is invalid

Closes: angular#15056

Author: Narretz

src/ng/compile.js

@@ -1087,10 +1087,11 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    * @returns {ng.$compileProvider} Self for chaining.
    */
   this.directive = function registerDirective(name, directiveFactory) {
+    assertArg(name, 'name');
     assertNotHasOwnProperty(name, 'directive');
     if (isString(name)) {
       assertValidDirectiveName(name);
-      assertArg(directiveFactory, 'directiveFactory');
+      assertArgFn(directiveFactory, 'directiveFactory', true);
       if (!hasDirectives.hasOwnProperty(name)) {
         hasDirectives[name] = [];
         $provide.factory(name + Suffix, ['$injector', '$exceptionHandler',

test/ng/compileSpec.js

@@ -214,6 +214,7 @@ describe('$compile', function() {
       });
       inject(function($compile) {});
     });
+
     it('should throw an exception if a directive name has leading or trailing whitespace', function() {
       module(function() {
         function assertLeadingOrTrailingWhitespaceInDirectiveName(name) {
@@ -230,6 +231,33 @@ describe('$compile', function() {
       inject(function($compile) {});
     });
 
+    it('should throw an exception if the directive name is not defined', function() {
+      module(function() {
+        expect(function() {
+          directive();
+        }).toThrowMinErr('ng','areq');
+      });
+      inject(function($compile) {});
+    });
+
+    it('should throw an exception if the directive factory is not a function', function() {
+      module(function() {
+        expect(function() {
+          directive('myDir');
+        }).toThrowMinErr('ng','areq');
+      });
+      inject(function($compile) {});
+    });
+
+    it('should accept array notation in the directive factory function', function() {
+      module(function() {
+        directive('myDir', ['log', function(log) {
+          expect(log).toBe(jasmine.any('Function'));
+        }]);
+      });
+      inject(function($compile) {});
+    });
+
     it('should preserve context within declaration', function() {
       module(function() {
         directive('ff', function(log) {