Skip to content

Commit 677962b

Browse files
committed
squash!
This will provide feedback to contributors without getting in the way of writing invalid commit messages locally. The git hook integration is turned off. Committers who push directly to the repo can be expected to use correct commit messages ;) Most changes go through PRs anyway. Related to angular#14888
1 parent 8255fd2 commit 677962b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,12 @@
9797
},
9898
"dependencies": {},
9999
"commitplease": {
100-
"style": "angular"
100+
"style": "angular",
101+
"nohook": true
101102
},
102103
"config": {
103104
"commitizen": {
104105
"path": "node_modules/cz-conventional-changelog"
105106
}
106107
}
107-
}
108+
}

scripts/travis/build.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ if [ "$JOB" == "ci-checks" ]; then
99
grunt ci-checks
1010
if [[ $TRAVIS_PULL_REQUEST != 'false' ]]; then
1111
# validate commit messages of all commits in the PR
12-
yarn run commitplease -- $TRAVIS_COMMIT_RANGE
12+
# convert commit range to 2 dots, as commitplease uses `git log`.
13+
# See https://github.com/travis-ci/travis-ci/issues/4596 for more info
14+
echo "Validate commit messages in PR."
15+
yarn run commitplease -- "${TRAVIS_COMMIT_RANGE/.../..}"
1316
fi
1417
elif [ "$JOB" == "unit" ]; then
1518
if [ "$BROWSER_PROVIDER" == "browserstack" ]; then

0 commit comments

Comments
 (0)