fix(ngOptions): ignore comment nodes when removing 'selected' attribute

Related angular#15454

Author: Narretz

src/ng/directive/select.js

@@ -70,7 +70,8 @@ var SelectController =
   };
 
   self.unselectEmptyOption = function() {
-    if (self.emptyOption) {
+    // Empty nodes with non-rendered ngIf can be comment nodes
+    if (self.emptyOption && self.emptyOption[0].nodeType === NODE_TYPE_ELEMENT) {
       self.emptyOption.removeAttr('selected');
     }
   };

test/ng/directive/ngOptionsSpec.js

@@ -2524,6 +2524,25 @@ describe('ngOptions', function() {
       }
     );
 
+
+    it('should select the correct option after linking when the ngIf expression is initially falsy', function() {
+      scope.values = [
+        {name:'black'},
+        {name:'white'},
+        {name:'red'}
+      ];
+      scope.selected = scope.values[2];
+
+      expect(function() {
+        createSingleSelect('<option ng-if="isBlank" value="">blank</option>');
+        scope.$apply();
+      }).not.toThrow();
+
+      expect(element.find('option')[2]).toBeMarkedAsSelected();
+      expect(linkLog).toEqual(['linkNgOptions']);
+    });
+
+
     it('should not throw when a directive compiles the blank option before ngOptions is linked', function() {
       expect(function() {
         createSelect({