Skip to content

Commit a16a195

Browse files
committed
Merge branch 'nyup-799_open-square-search-upgrade-webdriverio-from-5-x-to-7-x' into develop
2 parents 1098c25 + 6625115 commit a16a195

File tree

3 files changed

+1122
-520
lines changed

3 files changed

+1122
-520
lines changed

package.json

+9-9
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@
4343
"@vue/cli-service": "^3.8.3",
4444
"@vue/eslint-config-standard": "^4.0.0",
4545
"@vue/test-utils": "^1.0.0-beta.29",
46-
"@wdio/cli": "^5.10.4",
47-
"@wdio/local-runner": "^5.10.4",
48-
"@wdio/mocha-framework": "^5.10.1",
49-
"@wdio/selenium-standalone-service": "^5.9.3",
50-
"@wdio/spec-reporter": "^5.9.3",
51-
"@wdio/sync": "^5.10.1",
46+
"@wdio/cli": "^7.7.3",
47+
"@wdio/local-runner": "^7.7.3",
48+
"@wdio/mocha-framework": "^7.7.3",
49+
"@wdio/selenium-standalone-service": "^7.7.3",
50+
"@wdio/spec-reporter": "^7.7.3",
51+
"@wdio/sync": "^7.7.3",
5252
"babel-core": "7.0.0-bridge.0",
5353
"babel-eslint": "^10.0.1",
5454
"babel-jest": "^24.8.0",
@@ -71,11 +71,11 @@
7171
"sass-loader": "^7.0.1",
7272
"vue-jest": "^3.0.4",
7373
"vue-template-compiler": "^2.6.10",
74-
"webdriverio": "^5.10.4"
74+
"webdriverio": "^7.7.3"
7575
},
7676
"engines": {
77-
"node": ">= 6.0.0",
78-
"npm": ">= 3.0.0"
77+
"node": ">= 14.0.0",
78+
"npm": ">= 7.0.0"
7979
},
8080
"jest": {
8181
"moduleFileExtensions": [

tests/browser/conf/wdio.main.conf.js

+22-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,20 @@ exports.config = {
7070
// and 30 processes will get spawned. The property handles how many capabilities
7171
// from the same test should run tests.
7272
//
73-
maxInstances : 6,
73+
// NOTE: The above description of maxInstances from WebdriverIO does not appear to be correct.
74+
// maxInstances seems to determine how many total browser instances can be open at once.
75+
// If there are for example 9 test files and 2 capabilities (Firefox and Chrome, say) and
76+
// maxInstances is set to 9, webdriverio will open 5 Chrome windows and 4 Firefox windows.
77+
//
78+
// See this ticket:
79+
//
80+
// "Open Square search: Firefox browser tests failing in prod with connection failure errors"
81+
// https://jira.nyu.edu/jira/browse/NYUP-682
82+
//
83+
// ...for reason why Firefox must be limited to a single instance. We therefore
84+
// set global maxInstances to 7 to allow for 6 Chrome instances, one for each
85+
// test suite, and one single Firefox instance.
86+
maxInstances : 7,
7487
//
7588
// If you have trouble getting all important capabilities together, check out the
7689
// Sauce Labs platform configurator - a great tool to configure your capabilities:
@@ -98,7 +111,14 @@ exports.config = {
98111
// maxInstances can get overwritten per capability. So if you have an in-house Selenium
99112
// grid with only 5 firefox instances available you can make sure that not more than
100113
// 5 instances get started at a time.
101-
// maxInstances : 5,
114+
115+
// See this ticket:
116+
//
117+
// "Open Square search: Firefox browser tests failing in prod with connection failure errors"
118+
// https://jira.nyu.edu/jira/browse/NYUP-682
119+
//
120+
// ...for reason why Firefox must be limited to a single instance.
121+
maxInstances : 1,
102122
//
103123
browserName : 'firefox',
104124
'moz:firefoxOptions' : {

0 commit comments

Comments
 (0)