Adding VersionManager.create_latest and using it where applicable.

Author: gregmuellegger

readthedocs/privacy/backend.py

@@ -3,6 +3,8 @@
 
 from guardian.shortcuts import get_objects_for_user
 
+from builds.constants import LATEST
+from builds.constants import LATEST_VERBOSE_NAME
 from builds.constants import STABLE
 from builds.constants import STABLE_VERBOSE_NAME
 from projects import constants
@@ -125,7 +127,19 @@ def create_stable(self, **kwargs):
             'type': 'branch',
         }
         defaults.update(kwargs)
-        return self.create(**kwargs)
+        return self.create(**defaults)
+
+    def create_latest(self, **kwargs):
+        defaults = {
+            'slug': LATEST,
+            'verbose_name': LATEST_VERBOSE_NAME,
+            'machine': True,
+            'active': True,
+            'identifier': LATEST,
+            'type': 'branch',
+        }
+        defaults.update(kwargs)
+        return self.create(**defaults)
 
 
 class AdminPermission(object):

readthedocs/rtd_tests/tests/test_404.py

@@ -2,9 +2,6 @@
 
 from django.test import TestCase
 
-from builds.constants import LATEST
-from builds.constants import LATEST_VERBOSE_NAME
-from builds.models import Version
 from projects.models import Project
 
 
@@ -14,9 +11,7 @@ class Testmaker(TestCase):
     def setUp(self):
         self.client.login(username='eric', password='test')
         self.pip = Project.objects.get(slug='pip')
-        self.latest = Version.objects.create(project=self.pip, identifier=LATEST,
-                               verbose_name=LATEST_VERBOSE_NAME, slug=LATEST,
-                               active=True)
+        self.latest = self.pip.versions.create_latest()
         self.pip_es = Project.objects.create(name="PIP-ES", slug='pip-es', language='es', main_language_project=self.pip)
 
     def test_project_does_not_exist(self):

readthedocs/rtd_tests/tests/test_bookmarks.py

@@ -81,7 +81,7 @@ def test_delete_bookmark_with_json(self):
 
         post_data = {
             "project": self.project.slug,
-            "version": 'latest',
+            "version": LATEST,
             "page": "",
             "url": "",
         }

readthedocs/rtd_tests/tests/test_footer.py

@@ -2,9 +2,6 @@
 
 from django.test import TestCase
 
-from builds.constants import LATEST
-from builds.constants import LATEST_VERBOSE_NAME
-from builds.models import Version
 from projects.models import Project
 
 
@@ -14,9 +11,7 @@ class Testmaker(TestCase):
     def setUp(self):
         self.client.login(username='eric', password='test')
         self.pip = Project.objects.get(slug='pip')
-        self.latest = Version.objects.create(project=self.pip, identifier=LATEST,
-                               verbose_name=LATEST_VERBOSE_NAME, slug=LATEST,
-                               active=True)
+        self.latest = self.pip.versions.create_latest()
 
     def test_footer(self):
         r = self.client.get('/api/v2/footer_html/?project=pip&version=latest&page=index', {})

readthedocs/rtd_tests/tests/test_redirects.py

@@ -2,8 +2,6 @@
 from django.test.utils import override_settings
 
 from builds.constants import LATEST
-from builds.constants import LATEST_VERBOSE_NAME
-from builds.models import Version
 from projects.models import Project
 from redirects.models import Redirect
 
@@ -29,9 +27,7 @@ def setUp(self):
              'description': 'wat',
              'documentation_type': 'sphinx'})
         pip = Project.objects.get(slug='pip')
-        Version.objects.create(project=pip, identifier=LATEST,
-                               verbose_name=LATEST_VERBOSE_NAME, slug=LATEST,
-                               active=True)
+        pip.versions.create_latest()
 
     def test_proper_url_no_slash(self):
         r = self.client.get('/docs/pip')
@@ -198,9 +194,7 @@ def setUp(self):
              'description': 'wat',
              'documentation_type': 'sphinx'})
         self.pip = Project.objects.get(slug='pip')
-        Version.objects.create(project=self.pip, identifier=LATEST,
-                               verbose_name=LATEST_VERBOSE_NAME, slug=LATEST,
-                               active=True)
+        self.pip.versions.create_latest()
 
     @override_settings(USE_SUBDOMAIN=True)
     def test_redirect_root(self):

readthedocs/rtd_tests/tests/test_repo_parsing.py

@@ -2,9 +2,6 @@
 
 from django.test import TestCase
 
-from builds.constants import LATEST
-from builds.constants import LATEST_VERBOSE_NAME
-from builds.models import Version
 from projects.models import Project
 
 
@@ -14,9 +11,7 @@ class TestRepoParsing(TestCase):
     def setUp(self):
         self.client.login(username='eric', password='test')
         self.pip = Project.objects.get(slug='pip')
-        self.version = Version.objects.create(project=self.pip, identifier=LATEST,
-                               verbose_name=LATEST_VERBOSE_NAME, slug=LATEST,
-                               active=True)
+        self.version = self.pip.versions.create_latest()
 
     def test_github(self):
         self.pip.repo = 'https://github.com/user/repo'