Use lodash-es instead of lodash

When ESLint is configured to prefer TypeScript modules over JavaScript
(even in JavaScript files), attempting to import a named export from
`lodash` fails the `import/named` rule with something like:

    capitalize not found in 'lodash'

This seems to happen because `index.d.ts` links to other `.d.ts` files
via `/// <reference ...>`, and either `eslint-plugin-import` or
`eslint-import-resolver-typescript` does not know to follow those links.
(I say "either" because I haven't quite been able to figure out where the
exact issue is. The current maintainer of
`eslint-import-resolver-typescript` hasn't provided any useful
information; [here][1] is the closest issue on GitHub I've been able to
find that could explain something.) However, `lodash-es` does not
exhibit this issue, as its `index.d.ts` just imports types for
individual functions from other files instead of using `/// <reference
...>`.

[1]: import-js/eslint-import-resolver-typescript#31

Author: mcmire

app/scripts/controllers/incoming-transactions.test.js

@@ -2,7 +2,7 @@ import { strict as assert } from 'assert';
 import sinon from 'sinon';
 import proxyquire from 'proxyquire';
 import nock from 'nock';
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 import waitUntilCalled from '../../../test/lib/wait-until-called';
 import {

app/scripts/controllers/metametrics.js

@@ -1,4 +1,4 @@
-import { merge, omit, omitBy } from 'lodash';
+import { merge, omit, omitBy } from 'lodash-es';
 import { ObservableStore } from '@metamask/obs-store';
 import { bufferToHex, keccak } from 'ethereumjs-util';
 import { generateUUID } from 'pubnub';

app/scripts/controllers/permissions/selectors.test.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { getChangedAccounts, getPermittedAccountsByOrigin } from './selectors';
 
 describe('PermissionController selectors', () => {

app/scripts/controllers/swaps.js

@@ -2,7 +2,7 @@ import { ethers } from 'ethers';
 import log from 'loglevel';
 import BigNumber from 'bignumber.js';
 import { ObservableStore } from '@metamask/obs-store';
-import { mapValues, cloneDeep } from 'lodash';
+import { mapValues, cloneDeep } from 'lodash-es';
 import abi from 'human-standard-token-abi';
 import { calcTokenAmount } from '../../../ui/helpers/utils/token-util';
 import { calcGasTotal } from '../../../ui/pages/send/send.utils';

app/scripts/controllers/swaps.test.js

@@ -2,7 +2,7 @@ import { strict as assert } from 'assert';
 import sinon from 'sinon';
 
 import { ethers } from 'ethers';
-import { mapValues } from 'lodash';
+import { mapValues } from 'lodash-es';
 import BigNumber from 'bignumber.js';
 import {
   ROPSTEN_NETWORK_ID,

app/scripts/controllers/transactions/lib/tx-state-history-helpers.js

@@ -1,5 +1,5 @@
 import jsonDiffer from 'fast-json-patch';
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 /**
  * converts non-initial history entries into diffs

app/scripts/controllers/transactions/tx-gas-utils.js

@@ -1,7 +1,7 @@
 import EthQuery from 'ethjs-query';
 import log from 'loglevel';
 import { addHexPrefix } from 'ethereumjs-util';
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { hexToBn, BnMultiplyByFraction, bnToHex } from '../../lib/util';
 
 /**

app/scripts/controllers/transactions/tx-state-manager.js

@@ -1,7 +1,7 @@
 import EventEmitter from 'safe-event-emitter';
 import { ObservableStore } from '@metamask/obs-store';
 import log from 'loglevel';
-import { keyBy, mapValues, omitBy, pickBy, sortBy } from 'lodash';
+import { keyBy, mapValues, omitBy, pickBy, sortBy } from 'lodash-es';
 import createId from '../../../../shared/modules/random-id';
 import { TRANSACTION_STATUSES } from '../../../../shared/constants/transaction';
 import { METAMASK_CONTROLLER_EVENTS } from '../../metamask-controller';

app/scripts/lib/getObjStructure.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 // This will create an object that represents the structure of the given object
 // it replaces all values with the result of their type

app/scripts/lib/migrator/index.test.js

@@ -1,6 +1,6 @@
 /* eslint-disable jest/no-conditional-expect */
 import fs from 'fs';
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import liveMigrations from '../../migrations';
 import data from '../../first-time-state';
 import Migrator from '.';

app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js

@@ -1,6 +1,6 @@
 import { ethErrors, errorCodes } from 'eth-rpc-errors';
 import validUrl from 'valid-url';
-import { omit } from 'lodash';
+import { omit } from 'lodash-es';
 import { MESSAGE_TYPE } from '../../../../../shared/constants/app';
 import {
   isPrefixedFormattedHexString,

app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js

@@ -1,5 +1,5 @@
 import { ethErrors } from 'eth-rpc-errors';
-import { omit } from 'lodash';
+import { omit } from 'lodash-es';
 import { MESSAGE_TYPE } from '../../../../../shared/constants/app';
 import {
   ETH_SYMBOL,

app/scripts/lib/seed-phrase-verifier.test.js

@@ -2,7 +2,7 @@
  * @jest-environment node
  * https://github.com/facebook/jest/issues/7780
  */
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import KeyringController from 'eth-keyring-controller';
 import firstTimeState from '../first-time-state';
 import mockEncryptor from '../../../test/lib/mock-encryptor';

app/scripts/lib/util.js

@@ -1,7 +1,7 @@
 import extension from 'extensionizer';
 import { stripHexPrefix } from 'ethereumjs-util';
 import BN from 'bn.js';
-import { memoize } from 'lodash';
+import { memoize } from 'lodash-es';
 import {
   MAINNET_CHAIN_ID,
   TEST_CHAINS,

app/scripts/metamask-controller.js

@@ -3,7 +3,7 @@ import pump from 'pump';
 import { ObservableStore } from '@metamask/obs-store';
 import { storeAsStream } from '@metamask/obs-store/dist/asStream';
 import { JsonRpcEngine } from 'json-rpc-engine';
-import { debounce } from 'lodash';
+import { debounce } from 'lodash-es';
 import createEngineStream from 'json-rpc-middleware-stream/engineStream';
 import createFilterMiddleware from 'eth-json-rpc-filters';
 import createSubscriptionManager from 'eth-json-rpc-filters/subscriptionManager';

app/scripts/metamask-controller.test.js

@@ -1,6 +1,6 @@
 import { strict as assert } from 'assert';
 import sinon from 'sinon';
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import nock from 'nock';
 import { pubToAddress, bufferToHex } from 'ethereumjs-util';
 import { obj as createThoughStream } from 'through2';

app/scripts/migrations/002.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 2;
 

app/scripts/migrations/003.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 3;
 const oldTestRpc = 'https://rawtestrpc.metamask.io/';

app/scripts/migrations/004.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 4;
 

app/scripts/migrations/005.js

@@ -4,7 +4,7 @@ This migration moves state from the flat state trie into KeyringController subst
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 5;
 

app/scripts/migrations/006.js

@@ -4,7 +4,7 @@ This migration moves KeyringController.selectedAddress to PreferencesController.
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 6;
 

app/scripts/migrations/007.js

@@ -4,7 +4,7 @@ This migration breaks out the TransactionManager substate
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 7;
 

app/scripts/migrations/008.js

@@ -4,7 +4,7 @@ This migration breaks out the NoticeController substate
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 8;
 

app/scripts/migrations/009.js

@@ -4,7 +4,7 @@ This migration breaks out the CurrencyController substate
 
 */
 
-import { cloneDeep, merge } from 'lodash';
+import { cloneDeep, merge } from 'lodash-es';
 
 const version = 9;
 

app/scripts/migrations/010.js

@@ -4,7 +4,7 @@ This migration breaks out the ShapeShiftController substate
 
 */
 
-import { cloneDeep, merge } from 'lodash';
+import { cloneDeep, merge } from 'lodash-es';
 
 const version = 10;
 

app/scripts/migrations/011.js

@@ -4,7 +4,7 @@ This migration removes the discaimer state from our app, which was integrated in
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 11;
 

app/scripts/migrations/012.js

@@ -4,7 +4,7 @@ This migration modifies our notices to delete their body after being read.
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 12;
 

app/scripts/migrations/013.js

@@ -4,7 +4,7 @@ This migration modifies the network config from ambiguous 'testnet' to explicit
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 13;
 

app/scripts/migrations/014.js

@@ -4,7 +4,7 @@ This migration removes provider from config and moves it too NetworkController.
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 14;
 

app/scripts/migrations/015.js

@@ -5,7 +5,7 @@ to a 'failed' stated
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 15;

app/scripts/migrations/016.js

@@ -5,7 +5,7 @@ to a 'failed' stated
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 16;

app/scripts/migrations/017.js

@@ -4,7 +4,7 @@ This migration sets transactions who were retried and marked as failed to submit
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 17;

app/scripts/migrations/018.js

@@ -4,7 +4,7 @@ This migration updates "transaction state history" to diffs style
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import {
   snapshotFromTxMeta,
   migrateFromSnapshotsToDiffs,

app/scripts/migrations/019.js

@@ -5,7 +5,7 @@ whos nonce is too high
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 19;

app/scripts/migrations/020.js

@@ -6,7 +6,7 @@ so that we can version notices in the future.
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 20;
 

app/scripts/migrations/021.js

@@ -4,7 +4,7 @@ This migration removes the BlackListController from disk state
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 21;
 

app/scripts/migrations/022.js

@@ -4,7 +4,7 @@ This migration adds submittedTime to the txMeta if it is not their
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 22;

app/scripts/migrations/023.js

@@ -4,7 +4,7 @@ This migration removes transactions that are no longer usefull down to 40 total
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 23;

app/scripts/migrations/024.js

@@ -5,7 +5,7 @@ all unapproved transactions
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 24;

app/scripts/migrations/025.js

@@ -4,7 +4,7 @@
 normalizes txParams on unconfirmed txs
 
 */
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { addHexPrefix } from '../lib/util';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 

app/scripts/migrations/026.js

@@ -5,7 +5,7 @@ This migration moves the identities stored in the KeyringController
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 26;
 

app/scripts/migrations/027.js

@@ -4,7 +4,7 @@
 normalizes txParams on unconfirmed txs
 
 */
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 import { TRANSACTION_STATUSES } from '../../../shared/constants/transaction';
 
 const version = 27;

app/scripts/migrations/028.js

@@ -4,7 +4,7 @@
 normalizes txParams on unconfirmed txs
 
 */
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 28;
 

app/scripts/migrations/030.js

@@ -5,7 +5,7 @@ removes invalid chaids from preferences and networkController for custom rpcs
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 30;
 

app/scripts/migrations/031.js

@@ -1,5 +1,5 @@
 // next version number
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 31;
 

app/scripts/migrations/032.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 32;
 

app/scripts/migrations/033.js

@@ -5,7 +5,7 @@ Cleans up notices and assocated notice controller code
 
 */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 33;
 

app/scripts/migrations/034.js

@@ -1,4 +1,4 @@
-import { cloneDeep } from 'lodash';
+import { cloneDeep } from 'lodash-es';
 
 const version = 34;