Made all suggested changes

Author: mmegs-amzn

src/aws_encryption_sdk/keyring/multi_keyring.py

@@ -49,7 +49,7 @@ def __attrs_post_init__(self):
             raise TypeError("At least one of generator or children must be provided")
 
         _generator = (self.generator,) if self.generator is not None else ()
-        self._decryption_keyrings = itertools.chain(_generator, self.children)
+        self._decryption_keyrings = list(itertools.chain(_generator, self.children))
 
     def on_encrypt(self, encryption_materials):
         # type: (EncryptionMaterials) -> EncryptionMaterials

test/unit/test_keyring_multi.py

@@ -97,30 +97,26 @@ def test_parent():
 
 def test_keyring_with_generator_but_no_children():
     generator_keyring = RawAESKeyring(
-            key_namespace=_PROVIDER_ID,
-            key_name=_KEY_ID,
-            wrapping_key=_WRAPPING_KEY_AES,
-            wrapping_algorithm=WrappingAlgorithm.AES_256_GCM_IV12_TAG16_NO_PADDING,
-        )
-    test_multi_keyring = MultiKeyring(
-        generator=generator_keyring
+        key_namespace=_PROVIDER_ID,
+        key_name=_KEY_ID,
+        wrapping_key=_WRAPPING_KEY_AES,
+        wrapping_algorithm=WrappingAlgorithm.AES_256_GCM_IV12_TAG16_NO_PADDING,
     )
+    test_multi_keyring = MultiKeyring(generator=generator_keyring)
     assert test_multi_keyring.generator is generator_keyring
     assert not test_multi_keyring.children
 
 
 def test_keyring_with_children_but_no_generator():
     children_keyring = [
-            RawAESKeyring(
-                key_namespace=_PROVIDER_ID,
-                key_name=_KEY_ID,
-                wrapping_key=_WRAPPING_KEY_AES,
-                wrapping_algorithm=WrappingAlgorithm.AES_256_GCM_IV12_TAG16_NO_PADDING,
-            )
-        ]
-    test_multi_keyring = MultiKeyring(
-        children=children_keyring
-    )
+        RawAESKeyring(
+            key_namespace=_PROVIDER_ID,
+            key_name=_KEY_ID,
+            wrapping_key=_WRAPPING_KEY_AES,
+            wrapping_algorithm=WrappingAlgorithm.AES_256_GCM_IV12_TAG16_NO_PADDING,
+        )
+    ]
+    test_multi_keyring = MultiKeyring(children=children_keyring)
     assert test_multi_keyring.children is children_keyring
     assert test_multi_keyring.generator is None
 
@@ -151,7 +147,7 @@ def test_decryption_keyrings():
     assert test_multi_keyring.generator in test_multi_keyring._decryption_keyrings
     for child_keyring in test_multi_keyring.children:
         assert child_keyring in test_multi_keyring._decryption_keyrings
-    # assert len(list(test_multi_keyring._decryption_keyrings)) == len(test_multi_keyring.children) + 1
+    assert len(test_multi_keyring._decryption_keyrings) == len(test_multi_keyring.children) + 1
 
 
 def test_on_encrypt_with_no_generator_no_data_encryption_key():