Use output instead of event specific actions

Use event type to determine need of release

Author: Hi-Fi

.github/workflows/maven.yml

@@ -56,19 +56,25 @@ jobs:
           ${{ matrix.install_dependencies }}
           ${{ matrix.set_display }}
       - name: Build with Maven
-        run: mvn -B -ntp -q verify --file pom.xml -P 'build,${{ matrix.browser }}'
+        run: |
+          mvn -B -ntp -q verify --file pom.xml -P 'build,${{ matrix.browser }}'
       - name: Delete output.xml (on Win)
         run: |
           Get-ChildItem target/robotframework-reports -Include *output.xml -Recurse | Remove-Item
           echo "REPORT_FILE=$(Get-ChildItem target/robotframework-reports -Include *report.html -Recurse -Name)" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+          echo "SHA=$(("${{ github.event_name }}" -eq "push") ? "${{ github.sha }}" : "${{ github.event.pull_request.head.sha }}")" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
         if: always() && runner.os == 'Windows'
 
       - name: Delete output.xml (on Unix-like)
         run: |
           find target/robotframework-reports -type f -name '*output.xml' -exec rm {} +
           echo "REPORT_FILE=$(find target/robotframework-reports -type f -name '*report.html' | sed 's#.*/##')" >> $GITHUB_ENV
+          echo "SHA=$([ "${{ github.event_name }}" == "push" ] && echo "${{ github.sha }}" || echo "${{ github.event.pull_request.head.sha }}")" >> $GITHUB_ENV
         if: always() && runner.os != 'Windows'
 
+      - name: Print actual triggering commit
+        run: echo "${{ env.SHA }}"
+        
       - name: Archive acceptances test results
         uses: actions/[email protected]
         with:
@@ -92,33 +98,18 @@ jobs:
         with:
           route: POST /repos/{repository}/statuses/{sha}
           repository: ${{ github.repository }}
-          sha: ${{ github.event.pull_request.head.sha }}
+          sha: "${{env.SHA}}"
           state: "${{steps.upload_results.outputs.JOB_STATUS}}"
           target_url: "${{steps.upload_results.outputs.REPORT_URL}}"
           description: "Link to test report."
           context: at-results-${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.java-version }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        if: always() && job.status == 'failure' && github.event.pull_request
-
-      - uses: octokit/request-action@7e93b91076fad3920c29d44eb2a6311d929db3dd
-        name: Update status with Github Status API
-        id: update_status_push
-        with:
-          route: POST /repos/{repository}/statuses/{sha}
-          repository: ${{ github.repository }}
-          sha: ${{ github.sha }}
-          state: "${{env.JOB_STATUS}}"
-          target_url: "${{env.REPORT_URL}}"
-          description: "Link to test report."
-          context: at-results-${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.java-version }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        if: always() && job.status == 'failure' && github.event.push
+        if: always() && job.status == 'failure'
 
   release:
     needs: [build_and_test]
-    if: github.event.push
+    if: github.event_name == 'push'
     runs-on: ubuntu-latest
     name: Release package
     steps:
@@ -135,4 +126,4 @@ jobs:
           gpg_passphrase: ${{ secrets.gpg_passphrase }}
           nexus_username: ${{ secrets.nexus_username }}
           nexus_password: ${{ secrets.nexus_password }}
-          maven_args: -DskipTests
+          maven_args: -DskipTests

pom.xml

@@ -160,7 +160,7 @@
 		<dependency>
 		    <groupId>org.seleniumhq.selenium</groupId>
 		    <artifactId>htmlunit-driver</artifactId>
-		    <version>2.52.0</version>
+		    <version>2.53.0</version>
 		    <exclusions>
                 <exclusion>
                     <groupId>org.seleniumhq.selenium</groupId>
@@ -344,7 +344,7 @@
 						<!-- Weave the failure handler into the code -->
 						<groupId>org.codehaus.mojo</groupId>
 						<artifactId>aspectj-maven-plugin</artifactId>
-						<version>1.11</version>
+						<version>1.14.0</version>
 						<executions>
 							<execution>
 								<goals>

src/test/robotframework/testsuites/UnitTests/WhatAreCookies.robot

@@ -1,10 +1,12 @@
 *** Settings ***
 Resource          ../../settings/Settings.robot
+Library    String
 
 *** Test Cases ***
 Cookies
     Open Browser    http://www.whatarecookies.com/cookietest.asp    ${browser}    mainbrowser
     Handle Cookie Consent    cookieconsent_btn
-    ${all_cookies}=    Get Cookies
-    ${test}=    Get Cookie Value    cookieconsent
+    ${all_cookies}    Get Cookies
+    ${first cookie name}   Split String    ${all_cookies}    =
+    ${test}    Get Cookie Value    ${first cookie name}[0]
     Close Browser