Skip to content

Commit b1150db

Browse files
author
Doris Tam
committed
Revert "Fix navigation from edit/add to upload queue"
This reverts commit ff7e583.
1 parent 7a51431 commit b1150db

File tree

6 files changed

+10
-17
lines changed

6 files changed

+10
-17
lines changed

MaharaMobile/src/components/UploadForm/UploadForm.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ const UploadForm = (props: Props) => {
297297

298298
// upon successful upload, remove the AddFile screen from the navigation stack
299299
props.navigation.dispatch(StackActions.popToTop());
300-
// then take user to Upload queue screen
301-
props.navigation.navigate('Upload queue tab', {added: true});
300+
// then take user to PendingScreen
301+
props.navigation.navigate('Pending', {added: true});
302302
};
303303

304304
const updateTitle = (newTitle: string) => {
@@ -493,7 +493,7 @@ const UploadForm = (props: Props) => {
493493
navigation={props.navigation}
494494
onPress={() => {
495495
props.navigation.popToTop();
496-
props.navigation.navigate('Upload queue tab');
496+
props.navigation.navigate('Pending');
497497
}}
498498
/>
499499
)}

MaharaMobile/src/navigation/StackNavigators.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import LoginMethodScreen, {
1919
LoginMethodScreenOptions
2020
} from '../screens/LoginMethodScreen/LoginMethodScreen';
2121
import MenuScreen from '../screens/MenuScreen/MenuScreen';
22-
import UploadQueueScreen from '../screens/UploadQueueScreen/UploadQueueScreen';
22+
import PendingScreen from '../screens/PendingScreen/PendingScreen';
2323
import PreferencesScreen from '../screens/PreferencesScreen/PreferencesScreen';
2424
import PrivacyScreen from '../screens/PrivacyScreen/PrivacyScreen';
2525
import SelectMediaScreen from '../screens/SelectMediaScreen/SelectMediaScreen';
@@ -73,7 +73,7 @@ export const PendingItemsNavigator = () => (
7373
<PendingItems.Navigator screenOptions={headerConfigForTabStacks}>
7474
<PendingItems.Screen
7575
name="Pending"
76-
component={UploadQueueScreen}
76+
component={PendingScreen}
7777
options={{
7878
title: navigatorStrings().PENDING
7979
}}

MaharaMobile/src/screens/LoginMethodScreen/LoginMethodScreen.tsx

-7
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import React, {useEffect, useState} from 'react';
55
import {Alert, View} from 'react-native';
66
import {connect} from 'react-redux';
77
import {Dispatch} from 'redux';
8-
import {CommonActions} from '@react-navigation/routers';
98
import {
109
addToken,
1110
setDefaultBlogId,
@@ -49,7 +48,6 @@ import {
4948
import {userBlogJSONtoUserBlog} from '../../utils/helperFunctions';
5049
import flashMessage from '../../components/FlashMessage/FlashMessage';
5150
import styles from '../../assets/styles/variables';
52-
import CustomVerifyBackButton from '../../components/UI/CustomVerifyBackButton/CustomVerifyBackButton';
5351

5452
type Props = {
5553
dispatch: Dispatch;
@@ -224,11 +222,6 @@ export const LoginMethodScreenOptions = (navData) => {
224222

225223
if (headerTitle === 'sso') {
226224
return {
227-
headerLeft: (
228-
<CustomVerifyBackButton
229-
goBack={() => navData.navigation.dispatch(CommonActions.goBack())}
230-
/>
231-
),
232225
headerTitle: 'SSO'
233226
};
234227
}

MaharaMobile/src/screens/UploadQueueScreen/UploadQueueScreen.test.tsx renamed to MaharaMobile/src/screens/PendingScreen/PendingScreen.test.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Provider} from 'react-redux';
44
import renderer from 'react-test-renderer';
55
import configureStore from 'redux-mock-store';
66
import i18n from '../../i18n';
7-
import UploadQueueScreen from './UploadQueueScreen';
7+
import PendingScreen from './PendingScreen';
88

99
jest.mock('rn-fetch-blob', () => {
1010
return true;
@@ -30,7 +30,7 @@ it('renders correctly', () => {
3030
renderer.create(
3131
<Provider store={mockStore(initialState)}>
3232
<I18nProvider i18n={i18n} language="en">
33-
<UploadQueueScreen route={() => jest.mock('route', () => {})} />
33+
<PendingScreen route={() => jest.mock('route', () => {})} />
3434
</I18nProvider>
3535
</Provider>
3636
);

MaharaMobile/src/screens/UploadQueueScreen/UploadQueueScreen.tsx renamed to MaharaMobile/src/screens/PendingScreen/PendingScreen.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
import {GUEST_USERNAME} from '../../utils/constants';
3838
import {uploadItemToMahara} from '../../utils/helperFunctions';
3939
// Styles
40-
import pendingScreenStyles from './UploadQueueScreen.style';
40+
import pendingScreenStyles from './PendingScreen.style';
4141

4242
type Props = {
4343
uploadFiles: Array<PendingMFile>;
@@ -50,7 +50,7 @@ type Props = {
5050
route: {params: {added: boolean}};
5151
};
5252

53-
const UploadQueueScreen = (props: Props) => {
53+
const PendingScreen = (props: Props) => {
5454
const numUploadFiles = props.uploadFiles.length;
5555
const numUploadJEntries = props.uploadJEntries.length;
5656
const numUploadItems = numUploadFiles + numUploadJEntries;
@@ -255,4 +255,4 @@ const mapStateToProps = (state: RootState) => ({
255255
userName: selectUserName(state)
256256
});
257257

258-
export default connect(mapStateToProps)(UploadQueueScreen);
258+
export default connect(mapStateToProps)(PendingScreen);

0 commit comments

Comments
 (0)