Skip to content

Feature Request: Middleware #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhumrich opened this issue Jun 9, 2017 · 2 comments
Open

Feature Request: Middleware #152

nhumrich opened this issue Jun 9, 2017 · 2 comments

Comments

@nhumrich
Copy link

nhumrich commented Jun 9, 2017

As discussed in #128, it might be a cool idea to have a "middleware" layer in asyncpg where people can register their own code to be ran pre or post query.

One usecase is asyncpgsa, which is a project to allow sqlalchemy objects to be passed to asyncpg connection methods. If there was a middleware layer, asyncpgsa could simply be a middleware that would run right before asyncpg prepared the query to convert the sqlalchemy object into a string. This would make asyncpgsa stupid simple, and just be a conversion layer, allowing it to get out of the way, and let asyncpg be the source of truth for everything else.

Another use case is metrics. My org is starting to track metrics per endpoint and per database query. If asyncpg had middleware support, we could simply inject a middleware that tracked the query and the time it took, and send that information into our metric platform. This could be done today by wrapping asyncpg and adding a method around it that tracks the metrics. It would be amazing if instead asyncpg could be used directly, and the middleware handles that portion for me.

Middlewares could potentially be "added" when the pool is created. (they can only exist on a pool maybe?)

Anyways, I am happy to try to implement this if you would like, but first wanted to get a general discussion going on the topic.

@nhumrich nhumrich changed the title Feature Request: Feature Request: Middleware Jun 9, 2017
@vitaly-burovoy
Copy link
Contributor

Yes, existence of a "middleware" layer would also allow to support feature discussed in #9.

@dnk8n
Copy link

dnk8n commented Jun 7, 2024

Could another great use case be a poor man's Row Level Security (or more custom permissions functionality). Modifying the query with an additional clause, guarding against any queries accidentally forgetting this crucial component of the query.

Maybe there are more supported ways for me to implement the above though? Is this Issue a good fit or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants