From 76a61b44a9af8a0ab10a3e65875f843e218136fe Mon Sep 17 00:00:00 2001 From: anthony-y-zhu14 Date: Fri, 14 Mar 2025 15:18:50 -0400 Subject: [PATCH 1/3] patch: fix a issue when typescript version contains 0 would cause error to be thrown (e.g 5.0.4) --- src/transformer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/transformer.ts b/src/transformer.ts index 47228cd..d2c08dd 100755 --- a/src/transformer.ts +++ b/src/transformer.ts @@ -104,7 +104,7 @@ export default function transformer( const { tryParsePatterns } = tsInstance; const [tsVersionMajor, tsVersionMinor] = tsInstance.versionMajorMinor.split(".").map((v) => +v); - if (!tsVersionMajor || !tsVersionMinor) throw new Error("Expected version to be parsed"); + if (tsVersionMajor === undefined || tsVersionMinor === undefined) throw new Error("Expected version to be parsed"); const tsTransformPathsContext: TsTransformPathsContext = { compilerOptions, From bad81ff1ccc06f9e35460e705bc3aee7c4a52a6d Mon Sep 17 00:00:00 2001 From: anthony-y-zhu14 Date: Fri, 14 Mar 2025 19:49:41 -0400 Subject: [PATCH 2/3] chore: add test cases for 5.0.4 --- test/config.ts | 2 ++ test/package.json | 1 + test/yarn.lock | 23 +++++++++++++++++------ 3 files changed, 20 insertions(+), 6 deletions(-) diff --git a/test/config.ts b/test/config.ts index 5b1566e..b9a1ce5 100755 --- a/test/config.ts +++ b/test/config.ts @@ -1,6 +1,7 @@ import ts from "typescript"; import tsThree from "typescript-3"; import tsFourSeven from "typescript-4.7"; +import tsFiveZero from "typescript-5.0"; import tsFiveFive from "typescript-5.5"; import tsFiveSix from "typescript-5.6"; import path from "node:path"; @@ -8,6 +9,7 @@ import path from "node:path"; export const tsModules = [ ["3.6.5", tsThree, "typescript-3"], ["4.7.4", tsFourSeven, "typescript-4.7"], + ["5.0.4", tsFiveZero, "typescript-5.0"], ["5.5.4", tsFiveFive, "typescript-5.5"], ["5.6.3", tsFiveSix, "typescript-5.6"], ["Latest", ts, "typescript"], diff --git a/test/package.json b/test/package.json index f634066..11072bf 100644 --- a/test/package.json +++ b/test/package.json @@ -24,6 +24,7 @@ "typescript": "^5.7.2", "typescript-3": "npm:typescript@3.6.5", "typescript-4.7": "npm:typescript@4.7.4", + "typescript-5.0": "npm:typescript@5.0.4", "typescript-5.5": "npm:typescript@5.5.4", "typescript-5.6": "npm:typescript@5.6.3", "typescript-transform-paths": "portal:../" diff --git a/test/yarn.lock b/test/yarn.lock index 9cb3f63..54d6132 100644 --- a/test/yarn.lock +++ b/test/yarn.lock @@ -8097,6 +8097,7 @@ __metadata: typescript: "npm:^5.7.2" typescript-3: "npm:typescript@3.6.5" typescript-4.7: "npm:typescript@4.7.4" + typescript-5.0: "npm:typescript@5.0.4" typescript-5.5: "npm:typescript@5.5.4" typescript-5.6: "npm:typescript@5.6.3" typescript-transform-paths: "portal:../" @@ -9257,6 +9258,16 @@ __metadata: languageName: node linkType: hard +"typescript-5.0@npm:typescript@5.0.4": + version: 5.0.4 + resolution: "typescript@npm:5.0.4" + bin: + tsc: bin/tsc + tsserver: bin/tsserver + checksum: 10c0/2f5bd1cead194905957cb34e220b1d6ff1662399adef8ec1864f74620922d860ee35b6e50eafb3b636ea6fd437195e454e1146cb630a4236b5095ed7617395c2 + languageName: node + linkType: hard + "typescript-5.5@npm:typescript@5.5.4": version: 5.5.4 resolution: "typescript@npm:5.5.4" @@ -9288,22 +9299,22 @@ __metadata: linkType: soft "typescript@npm:^5.7.2": - version: 5.7.2 - resolution: "typescript@npm:5.7.2" + version: 5.8.2 + resolution: "typescript@npm:5.8.2" bin: tsc: bin/tsc tsserver: bin/tsserver - checksum: 10c0/a873118b5201b2ef332127ef5c63fb9d9c155e6fdbe211cbd9d8e65877283797cca76546bad742eea36ed7efbe3424a30376818f79c7318512064e8625d61622 + checksum: 10c0/5c4f6fbf1c6389b6928fe7b8fcd5dc73bb2d58cd4e3883f1d774ed5bd83b151cbac6b7ecf11723de56d4676daeba8713894b1e9af56174f2f9780ae7848ec3c6 languageName: node linkType: hard "typescript@patch:typescript@npm%3A^5.7.2#optional!builtin": - version: 5.7.2 - resolution: "typescript@patch:typescript@npm%3A5.7.2#optional!builtin::version=5.7.2&hash=5786d5" + version: 5.8.2 + resolution: "typescript@patch:typescript@npm%3A5.8.2#optional!builtin::version=5.8.2&hash=5786d5" bin: tsc: bin/tsc tsserver: bin/tsserver - checksum: 10c0/f3b8082c9d1d1629a215245c9087df56cb784f9fb6f27b5d55577a20e68afe2a889c040aacff6d27e35be165ecf9dca66e694c42eb9a50b3b2c451b36b5675cb + checksum: 10c0/5448a08e595cc558ab321e49d4cac64fb43d1fa106584f6ff9a8d8e592111b373a995a1d5c7f3046211c8a37201eb6d0f1566f15cdb7a62a5e3be01d087848e2 languageName: node linkType: hard From 9b591a23b38ed31389e14d92c117cff8c9f94cff Mon Sep 17 00:00:00 2001 From: Daniel Perez Alvarez Date: Sat, 15 Mar 2025 12:04:23 -0700 Subject: [PATCH 3/3] Revert "chore: add test cases for 5.0.4" This reverts commit bad81ff1ccc06f9e35460e705bc3aee7c4a52a6d. --- test/config.ts | 2 -- test/package.json | 1 - test/yarn.lock | 23 ++++++----------------- 3 files changed, 6 insertions(+), 20 deletions(-) diff --git a/test/config.ts b/test/config.ts index b9a1ce5..5b1566e 100755 --- a/test/config.ts +++ b/test/config.ts @@ -1,7 +1,6 @@ import ts from "typescript"; import tsThree from "typescript-3"; import tsFourSeven from "typescript-4.7"; -import tsFiveZero from "typescript-5.0"; import tsFiveFive from "typescript-5.5"; import tsFiveSix from "typescript-5.6"; import path from "node:path"; @@ -9,7 +8,6 @@ import path from "node:path"; export const tsModules = [ ["3.6.5", tsThree, "typescript-3"], ["4.7.4", tsFourSeven, "typescript-4.7"], - ["5.0.4", tsFiveZero, "typescript-5.0"], ["5.5.4", tsFiveFive, "typescript-5.5"], ["5.6.3", tsFiveSix, "typescript-5.6"], ["Latest", ts, "typescript"], diff --git a/test/package.json b/test/package.json index 11072bf..f634066 100644 --- a/test/package.json +++ b/test/package.json @@ -24,7 +24,6 @@ "typescript": "^5.7.2", "typescript-3": "npm:typescript@3.6.5", "typescript-4.7": "npm:typescript@4.7.4", - "typescript-5.0": "npm:typescript@5.0.4", "typescript-5.5": "npm:typescript@5.5.4", "typescript-5.6": "npm:typescript@5.6.3", "typescript-transform-paths": "portal:../" diff --git a/test/yarn.lock b/test/yarn.lock index 54d6132..9cb3f63 100644 --- a/test/yarn.lock +++ b/test/yarn.lock @@ -8097,7 +8097,6 @@ __metadata: typescript: "npm:^5.7.2" typescript-3: "npm:typescript@3.6.5" typescript-4.7: "npm:typescript@4.7.4" - typescript-5.0: "npm:typescript@5.0.4" typescript-5.5: "npm:typescript@5.5.4" typescript-5.6: "npm:typescript@5.6.3" typescript-transform-paths: "portal:../" @@ -9258,16 +9257,6 @@ __metadata: languageName: node linkType: hard -"typescript-5.0@npm:typescript@5.0.4": - version: 5.0.4 - resolution: "typescript@npm:5.0.4" - bin: - tsc: bin/tsc - tsserver: bin/tsserver - checksum: 10c0/2f5bd1cead194905957cb34e220b1d6ff1662399adef8ec1864f74620922d860ee35b6e50eafb3b636ea6fd437195e454e1146cb630a4236b5095ed7617395c2 - languageName: node - linkType: hard - "typescript-5.5@npm:typescript@5.5.4": version: 5.5.4 resolution: "typescript@npm:5.5.4" @@ -9299,22 +9288,22 @@ __metadata: linkType: soft "typescript@npm:^5.7.2": - version: 5.8.2 - resolution: "typescript@npm:5.8.2" + version: 5.7.2 + resolution: "typescript@npm:5.7.2" bin: tsc: bin/tsc tsserver: bin/tsserver - checksum: 10c0/5c4f6fbf1c6389b6928fe7b8fcd5dc73bb2d58cd4e3883f1d774ed5bd83b151cbac6b7ecf11723de56d4676daeba8713894b1e9af56174f2f9780ae7848ec3c6 + checksum: 10c0/a873118b5201b2ef332127ef5c63fb9d9c155e6fdbe211cbd9d8e65877283797cca76546bad742eea36ed7efbe3424a30376818f79c7318512064e8625d61622 languageName: node linkType: hard "typescript@patch:typescript@npm%3A^5.7.2#optional!builtin": - version: 5.8.2 - resolution: "typescript@patch:typescript@npm%3A5.8.2#optional!builtin::version=5.8.2&hash=5786d5" + version: 5.7.2 + resolution: "typescript@patch:typescript@npm%3A5.7.2#optional!builtin::version=5.7.2&hash=5786d5" bin: tsc: bin/tsc tsserver: bin/tsserver - checksum: 10c0/5448a08e595cc558ab321e49d4cac64fb43d1fa106584f6ff9a8d8e592111b373a995a1d5c7f3046211c8a37201eb6d0f1566f15cdb7a62a5e3be01d087848e2 + checksum: 10c0/f3b8082c9d1d1629a215245c9087df56cb784f9fb6f27b5d55577a20e68afe2a889c040aacff6d27e35be165ecf9dca66e694c42eb9a50b3b2c451b36b5675cb languageName: node linkType: hard