-
-
Notifications
You must be signed in to change notification settings - Fork 28
FIXED: dynamic type imports #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll test it one more manually time before merging. Thanks a lot for your contribution 😄
@all-contributors add @hedwiggggg for bug, test, and code |
I've put up a pull request to add @hedwiggggg! 🎉 |
I've tested it myself a little bit; so this for example won't work:
|
Okay, I think I could find a pattern to get the corresponding nodes for async imports.
Idk, if it's possible to simplify this; Unfortunately it seems to be not as easy as the type-only imports. |
REFACTORED: DRY
It turned out that the pattern is not so different from the require statement detection. I extended the tests and refactored the code a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution :-)
included in v1.1.14 |
Resolve #45