Skip to content

Improve debuggability of repeated resumeWithException invocations #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elizarov opened this issue Nov 14, 2018 · 3 comments
Closed

Improve debuggability of repeated resumeWithException invocations #833

elizarov opened this issue Nov 14, 2018 · 3 comments

Comments

@elizarov
Copy link
Contributor

Repeated invocation of CancellableContinuation.resumeWithException forwards it to "uncaught exception handler" but there is nothing in stack trace to help figuring the root cause of the problem (second invocation of resumeWithException). This shall be fixed by wrapping exception before forwarding it to uncaught exception handler.

@cbruegg
Copy link

cbruegg commented Nov 14, 2018

Would this also fix the issue described here where calling resumeWithException with an Exception created on a different thread than on which the suspending call was originally made resumes the coroutine with an Exception not containing the call to the suspending function?

@elizarov
Copy link
Contributor Author

@cbruegg That will be fixed by #792

@qwwdfsad
Copy link
Collaborator

I am closing this because this issue is no longer valid after #901 and #896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants