Skip to content

Integrate TestCoroutineContext with structured concurrency #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elizarov opened this issue Sep 10, 2018 · 4 comments
Closed

Integrate TestCoroutineContext with structured concurrency #541

elizarov opened this issue Sep 10, 2018 · 4 comments
Labels
enhancement

Comments

@elizarov
Copy link
Contributor

TestCoroutineContext (#297) should be integrated with structured concurrency (#410), so that all builders can be used inside the test context (custom builder-extension to be deprecated).
@qwwdfsad
Copy link
Collaborator

The good idea is to extract TestCoroutineContext and TestBase into a separate module, maybe getting rid of inheritance

@etonotieno etonotieno mentioned this issue Oct 25, 2018
Open
@objcode
Copy link
Contributor

objcode commented Dec 11, 2018

I'm taking a look at putting together a PR for this.

@objcode objcode mentioned this issue Dec 14, 2018
Closed
@objcode
Copy link
Contributor

objcode commented Dec 14, 2018

See #890 for a draft API that would do this integration. I expect it'll go through some changes during review.

Files are still in the same place - it's mostly up for API review right now. After #749 lands if this API is promising it should migrate to kotlinx-coroutines-test.

Thanks,
Sean

@villelaitila villelaitila mentioned this issue Jan 28, 2019
Open
@jonalmeida jonalmeida mentioned this issue Mar 20, 2019
Merged
2 tasks
@qwwdfsad
Copy link
Collaborator

Fixed in 1.2.1

@yorickhenning yorickhenning mentioned this issue Sep 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@objcode @elizarov @qwwdfsad