Skip to content

Mark CompletionStage<T>.await() as @DelicateCoroutinesApi #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dovchinnikov opened this issue Feb 19, 2025 · 2 comments
Open

Mark CompletionStage<T>.await() as @DelicateCoroutinesApi #4358

dovchinnikov opened this issue Feb 19, 2025 · 2 comments
Labels
design

Comments

@dovchinnikov
Copy link
Contributor

This is unexpected that await cancels the CompletableFuture on coroutine cancellation. Since it's named like Deferred.await, it's expected to behave the same way without requiring to convert to Deferred first.
@dovchinnikov
Copy link
Contributor Author

This could be already done before the decision on #4329.

@dkhalanskyjb
Copy link
Collaborator

I'd prefer to decide on #4329 in the near future. If we decide to deprecate CompletionStage.await anyway, then forcing everyone into an opt-in first is going to create unnecessary friction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dovchinnikov @dkhalanskyjb