Skip to content

Integration with Firebase for Android PR was lost? #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dzastinas opened this issue Feb 13, 2020 · 2 comments
Closed

Integration with Firebase for Android PR was lost? #1802

dzastinas opened this issue Feb 13, 2020 · 2 comments
Labels

Comments

@dzastinas
Copy link

dzastinas commented Feb 13, 2020

@qwwdfsad I can see Integration with Firebase for Android #426 PR was accepted

image

But it was not added to develop ?

FirebaseFirestore integration was added, but FirebaseDatabase integration was left out?

kotlinx-coroutines-firebase-android

@qwwdfsad
Copy link
Collaborator

As it was explained by @SUPERCILEX, there wasn't any "stream of values" primitive in coroutines at that moment and that Tasks API is used for all new Firebase/Play Services APIs that don't continuously update values, thus only part related to tasks was merged.

Currently, with the Flow, it is possible to integrate with Firebase even better, though maybe it's worth to ask Firebase folks to do so

@SUPERCILEX
Copy link
Contributor

Correct, and I don't believe JetBrains should be the one to maintain integrations with specific libraries. The play-tasks API makes sense because it's a general purpose async API used across dozens of libraries.

PS: Firestore flow APIs are already gaining momentum from the community and I would assume the RTDB will follow: firebase/firebase-android-sdk#1251, firebase/firebase-android-sdk#1252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants