Skip to content

Reactive guide: comments after code blocks out of sync with code #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Inego opened this issue Jun 16, 2019 · 1 comment
Closed

Reactive guide: comments after code blocks out of sync with code #1274

Inego opened this issue Jun 16, 2019 · 1 comment
Assignees
Labels
docs KDoc and API reference

Comments

@Inego
Copy link
Contributor

Inego commented Jun 16, 2019

https://github.com/Kotlin/kotlinx.coroutines/blob/master/reactive/coroutines-guide-reactive.md

  1. In the "Take until" section, the comment after the code block mentions the use function:

This code is using whileSelect as a nicer shortcut to while(select{...}) {} loop and Kotlin's use expression to close the channels on exit, which unsubscribes from the corresponding publishers.

But use here was refactored with consume back in January 2018.

  1. In "Merge", there is the following comment:

Notice, the use of coroutineContext in the invocation of launch coroutine builder.

coroutineContext is not passed to the invocation of launch (was refactored in September 2018).

@Inego Inego changed the title Reactive guide: obsolete mention of use in "Take until" Reactive guide: comments after code blocks out of sync with code Jun 16, 2019
@elizarov elizarov self-assigned this Jun 18, 2019
@elizarov elizarov added the docs KDoc and API reference label Jun 18, 2019
@elizarov
Copy link
Contributor

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs KDoc and API reference
Projects
None yet
Development

No branches or pull requests

2 participants