Fix and suppress some compilation warnings

Author: qwwdfsad

common/kotlinx-coroutines-core-common/src/SchedulerTask.common.kt

@@ -8,6 +8,8 @@ internal expect abstract class SchedulerTask() : Runnable
 
 internal expect interface SchedulerTaskContext
 
+@Suppress("EXTENSION_SHADOWED_BY_MEMBER")
 internal expect val SchedulerTask.taskContext: SchedulerTaskContext
 
+@Suppress("EXTENSION_SHADOWED_BY_MEMBER")
 internal expect inline fun SchedulerTaskContext.afterTask()

common/kotlinx-coroutines-core-common/src/channels/Channels.common.kt

@@ -60,8 +60,10 @@ public suspend inline fun <E> BroadcastChannel<E>.consumeEach(action: (E) -> Uni
  *           See [issue #254](https://github.com/Kotlin/kotlinx.coroutines/issues/254).
  */
 @ObsoleteCoroutinesApi
-public fun ReceiveChannel<*>.consumes(): CompletionHandler =
-    { cause: Throwable? -> cancel(cause) }
+public fun ReceiveChannel<*>.consumes(): CompletionHandler = { cause: Throwable? ->
+        @Suppress("DEPRECATION")
+        cancel(cause)
+    }
 
 /**
  * Returns a [CompletionHandler] that invokes [cancel][ReceiveChannel.cancel] on all the
@@ -77,6 +79,7 @@ public fun consumesAll(vararg channels: ReceiveChannel<*>): CompletionHandler =
         var exception: Throwable? = null
         for (channel in channels)
             try {
+                @Suppress("DEPRECATION")
                 channel.cancel(cause)
             } catch (e: Throwable) {
                 if (exception == null) {
@@ -112,6 +115,7 @@ public inline fun <E, R> ReceiveChannel<E>.consume(block: ReceiveChannel<E>.() -
         cause = e
         throw e
     } finally {
+        @Suppress("DEPRECATION")
         cancel(cause)
     }
 }
@@ -302,7 +306,7 @@ public suspend fun <E> ReceiveChannel<E>.firstOrNull(): E? =
  *           See [issue #254](https://github.com/Kotlin/kotlinx.coroutines/issues/254).
  */
 @ObsoleteCoroutinesApi
-public inline suspend fun <E> ReceiveChannel<E>.firstOrNull(predicate: (E) -> Boolean): E? {
+public suspend inline fun <E> ReceiveChannel<E>.firstOrNull(predicate: (E) -> Boolean): E? {
     consumeEach {
         if (predicate(it)) return it
     }

common/kotlinx-coroutines-core-common/test/AbstractCoroutineTest.kt

@@ -7,6 +7,7 @@ package kotlinx.coroutines
 import kotlin.coroutines.*
 import kotlin.test.*
 
+@Suppress("DEPRECATION") // cancel(cause)
 class AbstractCoroutineTest : TestBase() {
     @Test
     fun testNotifications() = runTest {

common/kotlinx-coroutines-core-common/test/AsyncTest.kt

@@ -8,6 +8,7 @@ package kotlinx.coroutines
 
 import kotlin.test.*
 
+@Suppress("DEPRECATION") // cancel(cause)
 class AsyncTest : TestBase() {
 
     @Test

core/kotlinx-coroutines-core/src/Builders.kt

@@ -65,6 +65,7 @@ private class BlockingCoroutine<T>(
     fun joinBlocking(): T {
         timeSource.registerTimeLoopThread()
         while (true) {
+            @Suppress("DEPRECATION")
             if (Thread.interrupted()) throw InterruptedException().also { cancel(it) }
             val parkNanos = eventLoop?.processNextEvent() ?: Long.MAX_VALUE
             // note: process next even may loose unpark flag, so check if completed before parking

core/kotlinx-coroutines-core/src/channels/Actor.kt

@@ -128,6 +128,7 @@ private open class ActorCoroutine<E>(
     active: Boolean
 ) : ChannelCoroutine<E>(parentContext, channel, active), ActorScope<E> {
     override fun onCancellation(cause: Throwable?) {
+        @Suppress("DEPRECATION")
         _channel.cancel(cause)
     }
 

core/kotlinx-coroutines-core/test/TestBase.kt

@@ -157,7 +157,7 @@ public actual open class TestBase actual constructor() {
         var exCount = 0
         var ex: Throwable? = null
         try {
-            runBlocking(block = block, context = CoroutineExceptionHandler { context, e ->
+            runBlocking(block = block, context = CoroutineExceptionHandler { _, e ->
                 if (e is CancellationException) return@CoroutineExceptionHandler // are ignored
                 exCount++
                 when {

core/kotlinx-coroutines-core/test/exceptions/JobBasicCancellationTest.kt

@@ -14,6 +14,8 @@ import kotlin.test.*
  * parent is not cancelled on child cancellation and launch {}, Job(), async {} and
  * CompletableDeferred behave properly
  */
+
+@Suppress("DEPRECATION") // cancel(cause)
 class JobBasicCancellationTest : TestBase() {
 
     @Test

core/kotlinx-coroutines-core/test/exceptions/JobExceptionHandlingTest.kt

@@ -10,6 +10,7 @@ import org.junit.Test
 import java.io.*
 import kotlin.test.*
 
+@Suppress("DEPRECATION") // cancel(cause)
 class JobExceptionHandlingTest : TestBase() {
 
     @Test

core/kotlinx-coroutines-core/test/exceptions/SuppresionTests.kt renamed to core/kotlinx-coroutines-core/test/exceptions/SuppressionTests.kt

@@ -5,16 +5,15 @@
 package kotlinx.coroutines.exceptions
 
 import kotlinx.coroutines.*
-import kotlinx.coroutines.exceptions.*
-import kotlinx.coroutines.selects.*
 import java.io.*
 import kotlin.coroutines.*
 import kotlin.test.*
 
 /*
  * Set of counterparts to common tests which check suppressed exceptions
  */
-class SuppresionTests : TestBase() {
+@Suppress("DEPRECATION")
+class SuppressionTests : TestBase() {
 
     @Test
     fun testCancellationTransparency() = runTest {
@@ -45,7 +44,7 @@ class SuppresionTests : TestBase() {
 
             override fun onCancellation(cause: Throwable?) {
                 assertTrue(cause is ArithmeticException)
-                assertTrue(cause!!.suppressed.isEmpty())
+                assertTrue(cause.suppressed.isEmpty())
                 expect(5)
             }
 
@@ -62,13 +61,13 @@ class SuppresionTests : TestBase() {
 
         coroutine.invokeOnCompletion(onCancelling = true) {
             assertTrue(it is ArithmeticException)
-            assertTrue(it!!.suppressed.isEmpty())
+            assertTrue(it.suppressed.isEmpty())
             expect(6)
         }
 
         coroutine.invokeOnCompletion {
             assertTrue(it is ArithmeticException)
-            checkException<IOException>(it!!.suppressed[0])
+            checkException<IOException>(it.suppressed[0])
             expect(8)
         }
 

core/kotlinx-coroutines-core/test/exceptions/WithContextCancellationStressTest.kt

@@ -23,6 +23,7 @@ class WithContextCancellationStressTest : TestBase() {
     }
 
     @Test
+    @Suppress("DEPRECATION")
     fun testConcurrentCancellation() = runBlocking {
         var ioException = 0
         var arithmeticException = 0

core/kotlinx-coroutines-core/test/exceptions/WithContextExceptionHandlingTest.kt

@@ -12,6 +12,7 @@ import java.io.*
 import kotlin.coroutines.*
 import kotlin.test.*
 
+@Suppress("DEPRECATION") // cancel(cause)
 @RunWith(Parameterized::class)
 class WithContextExceptionHandlingTest(private val mode: Mode) : TestBase() {
     enum class Mode { WITH_CONTEXT, ASYNC_AWAIT }

core/kotlinx-coroutines-core/test/scheduling/SchedulerTestBase.kt

@@ -2,6 +2,8 @@
  * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 
+@file:Suppress("UNUSED_VARIABLE")
+
 package kotlinx.coroutines.scheduling
 
 import kotlinx.atomicfu.*