Migrate BOM module to java-platform plugin

Author: Sergey Shatunov

build.gradle

@@ -62,7 +62,6 @@ buildscript {
         classpath "org.jetbrains.dokka:dokka-gradle-plugin:$dokka_version"
         classpath "org.jetbrains.kotlinx:atomicfu-gradle-plugin:$atomicfu_version"
         classpath "com.moowork.gradle:gradle-node-plugin:$gradle_node_version"
-        classpath "io.spring.gradle:dependency-management-plugin:$spring_dependency_management_version"
 
         // JMH plugins
         classpath "com.github.jengelman.gradle.plugins:shadow:5.1.0"

gradle.properties

@@ -26,7 +26,6 @@ mocha_version=4.1.0
 mocha_headless_chrome_version=1.8.2
 mocha_teamcity_reporter_version=2.2.2
 source_map_support_version=0.5.3
-spring_dependency_management_version=1.0.8.RELEASE
 
 # Settings
 kotlin.incremental.multiplatform=true

gradle/publish-bintray.gradle

@@ -6,7 +6,6 @@
 
 apply plugin: 'maven'
 apply plugin: 'maven-publish'
-apply plugin: "com.github.johnrengelman.shadow"
 
 apply from: project.rootProject.file('gradle/maven-central.gradle')
 
@@ -15,7 +14,16 @@ apply from: project.rootProject.file('gradle/maven-central.gradle')
 def isMultiplatform = project.name == "kotlinx-coroutines-core"
 def isBom = project.name == "kotlinx-coroutines-bom"
 
-if (!isMultiplatform) {
+if (!isBom) {
+    apply plugin: "com.github.johnrengelman.shadow"
+
+    // empty xxx-javadoc.jar
+    task javadocJar(type: Jar) {
+        archiveClassifier = 'javadoc'
+    }
+}
+
+if (!isMultiplatform && !isBom) {
     // Regular java modules need 'java-library' plugin for proper publication
     apply plugin: 'java-library'
 
@@ -26,11 +34,6 @@ if (!isMultiplatform) {
     }
 }
 
-// empty xxx-javadoc.jar
-task javadocJar(type: Jar) {
-    archiveClassifier = 'javadoc'
-}
-
 publishing {
     repositories {
         maven {
@@ -46,12 +49,7 @@ publishing {
         }
     }
 
-    if (isBom) {
-        // Configure mavenBom publication
-        publications {
-            mavenBom(MavenPublication) {}
-        }
-    } else if (!isMultiplatform) {
+    if (!isMultiplatform && !isBom) {
         // Configure java publications for regular non-MPP modules
         publications {
             maven(MavenPublication) {
@@ -106,4 +104,4 @@ task publishDevelopSnapshot() {
 }
 
 // Compatibility with old TeamCity configurations that perform :kotlinx-coroutines-core:bintrayUpload
-task bintrayUpload(dependsOn: publish)
+task bintrayUpload(dependsOn: publish)

kotlinx-coroutines-bom/build.gradle

@@ -2,23 +2,37 @@
  * Copyright 2016-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
  */
 plugins {
-    id 'io.spring.dependency-management'
+    id 'java-platform'
 }
 
 def name = project.name
 
-dependencyManagement {
-    dependencies {
+dependencies {
+    constraints {
         rootProject.subprojects.each {
-            if (ext.unpublished.contains(it.name)) return
+            if (rootProject.ext.unpublished.contains(it.name)) return
             if (it.name == name) return
             if (!it.plugins.hasPlugin('maven-publish')) return
             evaluationDependsOn(it.path)
             it.publishing.publications.all {
                 if (it.artifactId.endsWith("-kotlinMultiplatform")) return
                 if (it.artifactId.endsWith("-metadata")) return
-                dependency(group: it.groupId, name: it.artifactId, version: it.version)
+                // Skip platform artifacts (like *-linuxx64, *-macosx64)
+                // It leads to inconsistent bom when publishing from different platforms
+                // (e.g. on linux it will include only linuxx64 artifacts and no macosx64)
+                // It shouldn't be a problem as usually consumers need to use generic *-native artifact
+                // Gradle will choose correct variant by using metadata attributes
+                if (it.artifacts.any { it.extension == 'klib' }) return
+                api(group: it.groupId, name: it.artifactId, version: it.version)
             }
         }
     }
 }
+
+publishing {
+    publications {
+        mavenBom(MavenPublication) {
+            from components.javaPlatform
+        }
+    }
+}