File tree 3 files changed +5
-4
lines changed
3 files changed +5
-4
lines changed Original file line number Diff line number Diff line change @@ -22,6 +22,7 @@ dependencies {
22
22
23
23
sourceSets {
24
24
// Test that relies on Guava to reflectively check all Throwable subclasses in coroutines
25
+ // Also other non-specific tests piggyback on that one
25
26
withGuavaTest {
26
27
kotlin
27
28
compileClasspath + = sourceSets. test. runtimeClasspath
Original file line number Diff line number Diff line change @@ -8,7 +8,7 @@ import org.junit.Test
8
8
import kotlin.test.*
9
9
10
10
/*
11
- * Temporary test that verifies both signatures from jdk8 and from core source-sets are used
11
+ * Integration test that ensures both signatures from jdk8 and from core source-sets are used
12
12
*/
13
13
class Jdk8InCoreIntegration {
14
14
Original file line number Diff line number Diff line change @@ -44,9 +44,9 @@ The overall structure is just a hack to support the scenario we are interested i
44
44
* We would like to have two source-sets "core" and "jdk8"
45
45
* "jdk8" is allowed to use API from Java 8 and from "core"
46
46
* "core" is prohibited to use any API from "jdk8"
47
- * It is okay to have test in a single test source-set
48
- * We want to validate source-sets with animal sniffer separately
47
+ * It is okay to have tests in a single test source-set
49
48
* And we want to publish a **single** artifact kotlinx-coroutines-core.jar that contains classes from both source-sets
49
+ * Current limitation: only classes from "core" are checked with animal-sniffer
50
50
51
51
For that, we have following compilations:
52
52
* jvmMain compilation: [jvmCoreMain, jdk8Main]
@@ -145,7 +145,7 @@ kotlin {
145
145
146
146
/* Create compilation for jvmCore to prove that jvmMain does not rely on jdk8 */
147
147
compilations. create(' CoreMain' ) {
148
- /* jvmCore is automatically matched as 'defaultSourceSet' for the compilation */
148
+ /* jvmCore is automatically matched as 'defaultSourceSet' for the compilation, due to its name */
149
149
tasks. getByName(' check' ). dependsOn(compileKotlinTaskProvider)
150
150
}
151
151
}
You can’t perform that action at this time.
0 commit comments