Skip to content

Commit c09d1fc

Browse files
committed
~update comments
1 parent 448610d commit c09d1fc

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

integration-testing/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ dependencies {
2222

2323
sourceSets {
2424
// Test that relies on Guava to reflectively check all Throwable subclasses in coroutines
25+
// Also other non-specific tests piggyback on that one
2526
withGuavaTest {
2627
kotlin
2728
compileClasspath += sourceSets.test.runtimeClasspath

integration-testing/src/withGuavaTest/kotlin/Jdk8InCoreIntegration.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import org.junit.Test
88
import kotlin.test.*
99

1010
/*
11-
* Temporary test that verifies both signatures from jdk8 and from core source-sets are used
11+
* Integration test that ensures both signatures from jdk8 and from core source-sets are used
1212
*/
1313
class Jdk8InCoreIntegration {
1414

kotlinx-coroutines-core/build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ The overall structure is just a hack to support the scenario we are interested i
4444
* We would like to have two source-sets "core" and "jdk8"
4545
* "jdk8" is allowed to use API from Java 8 and from "core"
4646
* "core" is prohibited to use any API from "jdk8"
47-
* It is okay to have test in a single test source-set
48-
* We want to validate source-sets with animal sniffer separately
47+
* It is okay to have tests in a single test source-set
4948
* And we want to publish a **single** artifact kotlinx-coroutines-core.jar that contains classes from both source-sets
49+
* Current limitation: only classes from "core" are checked with animal-sniffer
5050
5151
For that, we have following compilations:
5252
* jvmMain compilation: [jvmCoreMain, jdk8Main]
@@ -145,7 +145,7 @@ kotlin {
145145

146146
/* Create compilation for jvmCore to prove that jvmMain does not rely on jdk8 */
147147
compilations.create('CoreMain') {
148-
/* jvmCore is automatically matched as 'defaultSourceSet' for the compilation */
148+
/* jvmCore is automatically matched as 'defaultSourceSet' for the compilation, due to its name */
149149
tasks.getByName('check').dependsOn(compileKotlinTaskProvider)
150150
}
151151
}

0 commit comments

Comments
 (0)