~ Review feedback

Author: elizarov

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-core.txt

@@ -1080,10 +1080,6 @@ public final class kotlinx/coroutines/selects/SelectKt {
 	public static final fun select (Lkotlin/jvm/functions/Function1;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 }
 
-public synthetic class kotlinx/coroutines/selects/SelectKtSelectOpSequenceNumberRefVolatile {
-	public fun <init> (J)V
-}
-
 public final class kotlinx/coroutines/selects/SelectUnbiasedKt {
 	public static final fun selectUnbiased (Lkotlin/jvm/functions/Function1;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 }

kotlinx-coroutines-core/common/src/internal/Atomic.kt

@@ -103,8 +103,6 @@ public abstract class AtomicDesc {
     lateinit var atomicOp: AtomicOp<*> // the reference to parent atomicOp, init when AtomicOp is created
     abstract fun prepare(op: AtomicOp<*>): Any? // returns `null` if prepared successfully
     abstract fun complete(op: AtomicOp<*>, failure: Any?) // decision == null if success
-
-    override fun toString(): String = "$classSimpleName@$hexAddress(atomicOp=$atomicOp)" // for debug
 }
 
 /**

kotlinx-coroutines-core/common/src/selects/Select.kt

@@ -205,7 +205,14 @@ private val UNDECIDED: Any = Symbol("UNDECIDED")
 private val RESUMED: Any = Symbol("RESUMED")
 
 // Global counter of all atomic select operations for their deadlock resolution
-private val selectOpSequenceNumber = atomic(1L)
+// The separate internal class is work-around for Atomicfu's current implementation that creates public classes
+// for static atomics
+internal class SeqNumber {
+    private val number = atomic(1L)
+    fun next() = number.incrementAndGet()
+}
+
+private val selectOpSequenceNumber = SeqNumber()
 
 @PublishedApi
 internal class SelectBuilderImpl<in R>(
@@ -541,7 +548,7 @@ internal class SelectBuilderImpl<in R>(
         @JvmField val desc: AtomicDesc
     ) : AtomicOp<Any?>() {
         // all select operations are totally ordered by their creating time using selectOpSequenceNumber
-        override val opSequence = selectOpSequenceNumber.getAndIncrement()
+        override val opSequence = selectOpSequenceNumber.next()
 
         init {
             desc.atomicOp = this