Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tensi… (#3869)

* Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tension between develop and K2 branches
* Remove obsolete workaround

Target ticket: KT-61577

Author: qwwdfsad

kotlinx-coroutines-core/common/test/AsyncTest.kt

@@ -8,7 +8,6 @@ package kotlinx.coroutines
 
 import kotlin.test.*
 
-@Suppress("DEPRECATION") // cancel(cause)
 class AsyncTest : TestBase() {
 
     @Test

kotlinx-coroutines-core/js/test/TestBase.kt

@@ -15,7 +15,6 @@ public actual typealias TestResult = Promise<Unit>
 
 public actual val isNative = false
 
-@Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
 public actual open class TestBase actual constructor() {
     public actual val isBoundByJsTestTimeout = true
     private var actionIndex = 0
@@ -27,8 +26,7 @@ public actual open class TestBase actual constructor() {
      * Throws [IllegalStateException] like `error` in stdlib, but also ensures that the test will not
      * complete successfully even if this exception is consumed somewhere in the test.
      */
-    @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
-    public actual fun error(message: Any, cause: Throwable? = null): Nothing {
+    public actual fun error(message: Any, cause: Throwable?): Nothing {
         if (cause != null) console.log(cause)
         val exception = IllegalStateException(
             if (cause == null) message.toString() else "$message; caused by $cause")

kotlinx-coroutines-core/jvm/test/TestBase.kt

@@ -55,8 +55,6 @@ public actual typealias TestResult = Unit
  * ```
  */
 @Suppress(
-    // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
-    "NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS",
     // fixme replace the suppress with AllowDifferentMembersInActual once stdlib is updated to 1.9.20 https://github.com/Kotlin/kotlinx.coroutines/issues/3846
     "ACTUAL_CLASSIFIER_MUST_HAVE_THE_SAME_MEMBERS_AS_NON_FINAL_EXPECT_CLASSIFIER"
 )
@@ -81,13 +79,12 @@ public actual open class TestBase(private var disableOutCheck: Boolean)  {
      */
     private lateinit var previousOut: PrintStream
 
-        /**
+    /**
      * Throws [IllegalStateException] like `error` in stdlib, but also ensures that the test will not
      * complete successfully even if this exception is consumed somewhere in the test.
      */
     // fixme replace the suppress with AllowDifferentMembersInActual once stdlib is updated to 1.9.20 https://github.com/Kotlin/kotlinx.coroutines/issues/3846
-    @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
-    public actual fun error(message: Any, cause: Throwable? = null): Nothing {
+    public actual fun error(message: Any, cause: Throwable?): Nothing {
         throw makeError(message, cause)
     }
 

kotlinx-coroutines-core/native/test/TestBase.kt

@@ -15,7 +15,6 @@ public actual val isNative = true
 @Suppress("ACTUAL_WITHOUT_EXPECT")
 public actual typealias TestResult = Unit
 
-@Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
 public actual open class TestBase actual constructor() {
     public actual val isBoundByJsTestTimeout = false
     private var actionIndex = atomic(0)
@@ -26,8 +25,7 @@ public actual open class TestBase actual constructor() {
      * Throws [IllegalStateException] like `error` in stdlib, but also ensures that the test will not
      * complete successfully even if this exception is consumed somewhere in the test.
      */
-    @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
-    public actual fun error(message: Any, cause: Throwable? = null): Nothing {
+    public actual fun error(message: Any, cause: Throwable?): Nothing {
         val exception = IllegalStateException(message.toString(), cause)
         if (error == null) error = exception
         throw exception