Check toMillis overflow in operators with Duration

Fix #868

Author: fvasco

integration/kotlinx-coroutines-jdk8/src/time/Time.kt

@@ -6,28 +6,42 @@ package kotlinx.coroutines.time
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.selects.SelectBuilder
 import java.time.Duration
-import java.util.concurrent.TimeUnit
 
 /**
  * "java.time" adapter method for [kotlinx.coroutines.delay]
  */
 public suspend fun delay(duration: Duration) =
-    kotlinx.coroutines.delay(duration.toMillis())
+    kotlinx.coroutines.delay(duration.toMillisOrMax())
 
 /**
  * "java.time" adapter method for [SelectBuilder.onTimeout]
  */
 public fun <R> SelectBuilder<R>.onTimeout(duration: Duration, block: suspend () -> R) =
-    onTimeout(duration.toMillis(), block)
+    onTimeout(duration.toMillisOrMax(), block)
 
 /**
  * "java.time" adapter method for [kotlinx.coroutines.withTimeout]
  */
 public suspend fun <T> withTimeout(duration: Duration, block: suspend CoroutineScope.() -> T): T =
-    kotlinx.coroutines.withTimeout(duration.toMillis(), block)
+    kotlinx.coroutines.withTimeout(duration.toMillisOrMax(), block)
 
 /**
  * "java.time" adapter method for [kotlinx.coroutines.withTimeoutOrNull]
  */
 public suspend fun <T> withTimeoutOrNull(duration: Duration, block: suspend CoroutineScope.() -> T): T? =
-    kotlinx.coroutines.withTimeoutOrNull(duration.toMillis(), block)
+    kotlinx.coroutines.withTimeoutOrNull(duration.toMillisOrMax(), block)
+
+/**
+ * Try to convert a [Duration] to milliseconds, negative durations are translated to `0`,
+ * too large durations are capped to `Duration.ofMillis(Long.MAX_VALUE)`.
+ */
+private fun Duration.toMillisOrMax(): Long {
+    // values of Duration.ofMillis(Long.MAX_VALUE)
+    val maxSeconds = 9223372036854775
+    val maxNanos = 807000000
+    return when {
+        isNegative -> 0
+        seconds < maxSeconds || seconds == maxSeconds && nano < maxNanos -> toMillis()
+        else -> Long.MAX_VALUE
+    }
+}

integration/kotlinx-coroutines-jdk8/test/time/TimeTest.kt

@@ -0,0 +1,53 @@
+/*
+ * Copyright 2016-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
+ */
+
+package kotlinx.coroutines.time
+
+import kotlinx.coroutines.*
+import org.hamcrest.core.*
+import org.junit.*
+import kotlinx.coroutines.CompletableDeferred
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.selects.select
+import java.time.temporal.ChronoUnit
+
+class TimeTest : TestBase() {
+
+    @Test
+    fun testDelay() {
+        runTest {
+            launch(start = CoroutineStart.UNDISPATCHED) {
+                delay(ChronoUnit.FOREVER.duration)
+            }
+                    .cancel()
+        }
+    }
+
+    @Test
+    fun testOnTimeout() {
+        runTest {
+            val completedJob: Job = CompletableDeferred(Unit)
+            select<Unit> {
+                onTimeout(ChronoUnit.FOREVER.duration) {}
+                onTimeout(ChronoUnit.FOREVER.duration.negated()) {}
+                completedJob.onJoin {}
+            }
+        }
+    }
+
+    @Test
+    fun testWithTimeout() {
+        runTest {
+            withTimeout(ChronoUnit.FOREVER.duration) {}
+        }
+    }
+
+    @Test
+    fun testWithTimeoutOrNull() {
+        runTest {
+            withTimeoutOrNull(ChronoUnit.FOREVER.duration) {}
+        }
+    }
+
+}