Flow performance improvements: mark crucial Flow DSL (unsafeFlow, collect, transform, map, mapNotNull, filter, filterNot, filterNotNull) as inline

Author: qwwdfsad

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-core.txt

@@ -792,7 +792,6 @@ public final class kotlinx/coroutines/flow/FlowKt {
 	public static final fun asFlow ([Ljava/lang/Object;)Lkotlinx/coroutines/flow/Flow;
 	public static final fun broadcastIn (Lkotlinx/coroutines/flow/Flow;Lkotlinx/coroutines/CoroutineScope;ILkotlinx/coroutines/CoroutineStart;)Lkotlinx/coroutines/channels/BroadcastChannel;
 	public static synthetic fun broadcastIn$default (Lkotlinx/coroutines/flow/Flow;Lkotlinx/coroutines/CoroutineScope;ILkotlinx/coroutines/CoroutineStart;ILjava/lang/Object;)Lkotlinx/coroutines/channels/BroadcastChannel;
-	public static final fun collect (Lkotlinx/coroutines/flow/Flow;Lkotlin/jvm/functions/Function2;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public static final fun combineLatest (Lkotlinx/coroutines/flow/Flow;Lkotlinx/coroutines/flow/Flow;Lkotlin/jvm/functions/Function3;)Lkotlinx/coroutines/flow/Flow;
 	public static final fun count (Lkotlinx/coroutines/flow/Flow;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;
 	public static final fun count (Lkotlinx/coroutines/flow/Flow;Lkotlin/jvm/functions/Function2;Lkotlin/coroutines/Continuation;)Ljava/lang/Object;

kotlinx-coroutines-core/common/src/flow/Builders.kt

@@ -58,7 +58,7 @@ public fun <T> flow(@BuilderInference block: suspend FlowCollector<T>.() -> Unit
  */
 @FlowPreview
 @PublishedApi
-internal fun <T> unsafeFlow(@BuilderInference block: suspend FlowCollector<T>.() -> Unit): Flow<T> {
+internal inline fun <T> unsafeFlow(@BuilderInference crossinline block: suspend FlowCollector<T>.() -> Unit): Flow<T> {
     return object : Flow<T> {
         override suspend fun collect(collector: FlowCollector<T>) {
             collector.block()

kotlinx-coroutines-core/common/src/flow/operators/Transform.kt

@@ -26,7 +26,7 @@ import kotlinx.coroutines.flow.unsafeFlow as flow
  * ```
  */
 @FlowPreview
-public fun <T, R> Flow<T>.transform(@BuilderInference transform: suspend FlowCollector<R>.(value: T) -> Unit): Flow<R> {
+public inline fun <T, R> Flow<T>.transform(@BuilderInference crossinline transform: suspend FlowCollector<R>.(value: T) -> Unit): Flow<R> {
     return flow {
         collect { value ->
             transform(value)
@@ -38,7 +38,7 @@ public fun <T, R> Flow<T>.transform(@BuilderInference transform: suspend FlowCol
  * Returns a flow containing only values of the original flow that matches the given [predicate].
  */
 @FlowPreview
-public fun <T> Flow<T>.filter(predicate: suspend (T) -> Boolean): Flow<T> = flow {
+public inline fun <T> Flow<T>.filter(crossinline predicate: suspend (T) -> Boolean): Flow<T> = flow {
     collect { value ->
         if (predicate(value)) emit(value)
     }
@@ -48,7 +48,7 @@ public fun <T> Flow<T>.filter(predicate: suspend (T) -> Boolean): Flow<T> = flow
  * Returns a flow containing only values of the original flow that do not match the given [predicate].
  */
 @FlowPreview
-public fun <T> Flow<T>.filterNot(predicate: suspend (T) -> Boolean): Flow<T> = flow {
+public inline fun <T> Flow<T>.filterNot(crossinline predicate: suspend (T) -> Boolean): Flow<T> = flow {
     collect { value ->
         if (!predicate(value)) emit(value)
     }
@@ -73,15 +73,15 @@ public fun <T: Any> Flow<T?>.filterNotNull(): Flow<T> = flow<T> {
  * Returns a flow containing the results of applying the given [transform] function to each value of the original flow.
  */
 @FlowPreview
-public fun <T, R> Flow<T>.map(transform: suspend (value: T) -> R): Flow<R> = transform { value ->
+public inline fun <T, R> Flow<T>.map(crossinline transform: suspend (value: T) -> R): Flow<R> = transform { value ->
     emit(transform(value))
 }
 
 /**
  * Returns a flow that contains only non-null results of applying the given [transform] function to each value of the original flow.
  */
 @FlowPreview
-public fun <T, R: Any> Flow<T>.mapNotNull(transform: suspend (value: T) -> R?): Flow<R> = transform { value ->
+public inline fun <T, R: Any> Flow<T>.mapNotNull(crossinline transform: suspend (value: T) -> R?): Flow<R> = transform { value ->
     val transformed = transform(value) ?: return@transform
     emit(transformed)
 }

kotlinx-coroutines-core/common/src/flow/terminal/Collect.kt

@@ -28,7 +28,7 @@ import kotlin.jvm.*
  * ```
  */
 @FlowPreview
-public suspend fun <T> Flow<T>.collect(action: suspend (value: T) -> Unit): Unit =
+public suspend inline fun <T> Flow<T>.collect(crossinline action: suspend (value: T) -> Unit): Unit =
     collect(object : FlowCollector<T> {
         override suspend fun emit(value: T) = action(value)
     })