Skip to content

Commit 28b073a

Browse files
committed
Update to 1.3-RC version, replace SuccessOrFailure with Result
1 parent 4da16c9 commit 28b073a

File tree

15 files changed

+21
-18
lines changed

15 files changed

+21
-18
lines changed

binary-compatibility-validator/reference-public-api/kotlinx-coroutines-core.txt

+2
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,10 @@ public abstract class kotlinx/coroutines/CoroutineDispatcher : kotlin/coroutines
154154
public fun <init> ()V
155155
public abstract fun dispatch (Lkotlin/coroutines/CoroutineContext;Ljava/lang/Runnable;)V
156156
public fun dispatchYield (Lkotlin/coroutines/CoroutineContext;Ljava/lang/Runnable;)V
157+
public fun get (Lkotlin/coroutines/CoroutineContext$Key;)Lkotlin/coroutines/CoroutineContext$Element;
157158
public fun interceptContinuation (Lkotlin/coroutines/Continuation;)Lkotlin/coroutines/Continuation;
158159
public fun isDispatchNeeded (Lkotlin/coroutines/CoroutineContext;)Z
160+
public fun minusKey (Lkotlin/coroutines/CoroutineContext$Key;)Lkotlin/coroutines/CoroutineContext;
159161
public final fun plus (Lkotlinx/coroutines/CoroutineDispatcher;)Lkotlinx/coroutines/CoroutineDispatcher;
160162
public fun releaseInterceptedContinuation (Lkotlin/coroutines/Continuation;)V
161163
public fun toString ()Ljava/lang/String;

build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ allprojects {
5454

5555
repositories {
5656
jcenter()
57+
maven { url 'http://dl.bintray.com/kotlin/kotlin-dev' }
5758
maven { url "https://kotlin.bintray.com/kotlin-dev" }
5859
maven { url "https://kotlin.bintray.com/kotlinx" }
5960
}

common/kotlinx-coroutines-core-common/src/AbstractContinuation.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ internal abstract class AbstractContinuation<in T>(
139139
return getSuccessfulResult(state)
140140
}
141141

142-
override fun resumeWith(result: SuccessOrFailure<T>) =
142+
override fun resumeWith(result: Result<T>) =
143143
resumeImpl(result.toState(), resumeMode)
144144

145145
public fun invokeOnCancellation(handler: CompletionHandler) {

common/kotlinx-coroutines-core-common/src/AbstractCoroutine.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public abstract class AbstractCoroutine<in T>(
101101
/**
102102
* Completes execution of this with coroutine with the specified result.
103103
*/
104-
public final override fun resumeWith(result: SuccessOrFailure<T>) {
104+
public final override fun resumeWith(result: Result<T>) {
105105
makeCompletingOnce(result.toState(), defaultResumeMode)
106106
}
107107

common/kotlinx-coroutines-core-common/src/Builders.common.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ private class RunContinuationUnintercepted<in T>(
236236
override val context: CoroutineContext,
237237
private val continuation: Continuation<T>
238238
): Continuation<T> {
239-
override fun resumeWith(result: SuccessOrFailure<T>) {
239+
override fun resumeWith(result: Result<T>) {
240240
withCoroutineContext(continuation.context) {
241241
continuation.resumeWith(result)
242242
}

common/kotlinx-coroutines-core-common/src/CompletedExceptionally.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import kotlin.coroutines.*
1010
/**
1111
* @suppress **This is unstable API and it is subject to change.**
1212
*/
13-
public fun <T> SuccessOrFailure<T>.toState(): Any? =
13+
public fun <T> Result<T>.toState(): Any? =
1414
if (isSuccess) getOrThrow() else CompletedExceptionally(exceptionOrNull()!!) // todo: need to do it better
1515

1616
/**

common/kotlinx-coroutines-core-common/src/Dispatched.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal class DispatchedContinuation<in T>(
2727
override val delegate: Continuation<T>
2828
get() = this
2929

30-
override fun resumeWith(result: SuccessOrFailure<T>) {
30+
override fun resumeWith(result: Result<T>) {
3131
val context = continuation.context
3232
if (dispatcher.isDispatchNeeded(context)) {
3333
_state = result.toState()
@@ -60,7 +60,7 @@ internal class DispatchedContinuation<in T>(
6060
}
6161

6262
@Suppress("NOTHING_TO_INLINE") // we need it inline to save us an entry on the stack
63-
inline fun resumeUndispatchedWith(result: SuccessOrFailure<T>) {
63+
inline fun resumeUndispatchedWith(result: Result<T>) {
6464
withCoroutineContext(context) {
6565
continuation.resumeWith(result)
6666
}

common/kotlinx-coroutines-core-common/src/selects/Select.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ internal class SelectBuilderImpl<in R>(
235235
}
236236

237237
// Resumes in MODE_DIRECT
238-
override fun resumeWith(result: SuccessOrFailure<R>) {
238+
override fun resumeWith(result: Result<R>) {
239239
doResume({ result.toState() }) {
240240
uCont.resumeWith(result)
241241
}

common/kotlinx-coroutines-core-common/test/selects/SelectBuilderImplTest.kt

+4-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class SelectBuilderImplTest {
1414
var resumed = false
1515
val delegate = object : Continuation<String> {
1616
override val context: CoroutineContext get() = EmptyCoroutineContext
17-
override fun resumeWith(result: SuccessOrFailure<String>) {
17+
override fun resumeWith(result: Result<String>) {
1818
check(result.getOrNull() == "OK")
1919
resumed = true
2020
}
@@ -39,7 +39,7 @@ class SelectBuilderImplTest {
3939
var resumed = false
4040
val delegate = object : Continuation<String> {
4141
override val context: CoroutineContext get() = EmptyCoroutineContext
42-
override fun resumeWith(result: SuccessOrFailure<String>) {
42+
override fun resumeWith(result: Result<String>) {
4343
check(result.getOrNull() == "OK")
4444
resumed = true
4545
}
@@ -64,7 +64,7 @@ class SelectBuilderImplTest {
6464
var resumed = false
6565
val delegate = object : Continuation<String> {
6666
override val context: CoroutineContext get() = EmptyCoroutineContext
67-
override fun resumeWith(result: SuccessOrFailure<String>) {
67+
override fun resumeWith(result: Result<String>) {
6868
check(result.exceptionOrNull() is TestException)
6969
resumed = true
7070
}
@@ -94,7 +94,7 @@ class SelectBuilderImplTest {
9494
var resumed = false
9595
val delegate = object : Continuation<String> {
9696
override val context: CoroutineContext get() = EmptyCoroutineContext
97-
override fun resumeWith(result: SuccessOrFailure<String>) {
97+
override fun resumeWith(result: Result<String>) {
9898
check(result.exceptionOrNull() is TestException)
9999
resumed = true
100100
}

core/kotlinx-coroutines-core/test/DelayJvmTest.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class DelayJvmTest : TestBase() {
6666
override val context: CoroutineContext
6767
get() = cont.context
6868

69-
override fun resumeWith(result: SuccessOrFailure<T>) {
69+
override fun resumeWith(result: Result<T>) {
7070
pool.execute { cont.resumeWith(result) }
7171
}
7272
}

core/kotlinx-coroutines-core/test/linearizability/LinTesting.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class LinTesting {
4545
override val context: CoroutineContext
4646
get() = EmptyCoroutineContext
4747

48-
override fun resumeWith(result: SuccessOrFailure<Any?>) {
48+
override fun resumeWith(result: kotlin.Result<Any?>) {
4949
val value = if (result.isSuccess) result.getOrNull() else result.exceptionOrNull()
5050
resumed.get() += OpResult(name, repr(value))
5151
}

gradle.properties

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Kotlin
2-
version=0.26.0-eap13-SNAPSHOT
2+
version=0.26.0-rc13-SNAPSHOT
33
group=org.jetbrains.kotlinx
4-
kotlin_version=1.3-M2
4+
kotlin_version=1.3.0-rc-6
55
kotlin_native_version=0.9
66

77
# Dependencies

integration/kotlinx-coroutines-guava/src/ListenableFuture.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ private class ListenableFutureCoroutine<T>(
106106
) : AbstractFuture<T>(), Continuation<T>, CoroutineScope {
107107
override val coroutineContext: CoroutineContext get() = context
108108
override val isActive: Boolean get() = context[Job]!!.isActive
109-
override fun resumeWith(result: SuccessOrFailure<T>) {
109+
override fun resumeWith(result: Result<T>) {
110110
result
111111
.onSuccess { set(it) }
112112
.onFailure { setException(it) }

integration/kotlinx-coroutines-jdk8/src/future/Future.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private class CompletableFutureCoroutine<T>(
107107
) : CompletableFuture<T>(), Continuation<T>, CoroutineScope {
108108
override val coroutineContext: CoroutineContext get() = context
109109
override val isActive: Boolean get() = context[Job]!!.isActive
110-
override fun resumeWith(result: SuccessOrFailure<T>) {
110+
override fun resumeWith(result: Result<T>) {
111111
result
112112
.onSuccess { complete(it) }
113113
.onFailure { completeExceptionally(it) }

integration/kotlinx-coroutines-quasar/src/Quasar.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private class CoroutineAsync<T>(
4747
override val context: CoroutineContext =
4848
GlobalScope.newCoroutineContext(Fiber.currentFiber().scheduler.executor.asCoroutineDispatcher())
4949

50-
override fun resumeWith(result: SuccessOrFailure<T>) {
50+
override fun resumeWith(result: Result<T>) {
5151
result
5252
.onSuccess { asyncCompleted(it) }
5353
.onFailure { asyncFailed(it) }

0 commit comments

Comments
 (0)