@@ -128,6 +128,8 @@ class PersistentListBuilderTest {
128
128
assertEquals(index, builder.first())
129
129
assertEquals(0 , builder.last())
130
130
assertEquals(index + 1 , builder.size)
131
+ // TODO: avoid list allocations using approach from addLastTests
132
+ // TODO: try to avoid n^2
131
133
assertEquals(List (index + 1 ) { index - it }, builder)
132
134
}
133
135
}
@@ -137,13 +139,14 @@ class PersistentListBuilderTest {
137
139
val builder = persistentListOf<Int >().builder()
138
140
139
141
val elementsToAdd = 10000
142
+ val allElements = List (elementsToAdd) { it }
140
143
repeat(times = elementsToAdd) { index ->
141
144
builder.add(index)
142
145
143
146
assertEquals(0 , builder[0 ])
144
147
assertEquals(index, builder[index])
145
148
assertEquals(index + 1 , builder.size)
146
- assertEquals(List (index + 1 ) { it } , builder)
149
+ assertEquals(allElements.subList( 0 , builder.size) , builder)
147
150
}
148
151
}
149
152
@@ -162,6 +165,7 @@ class PersistentListBuilderTest {
162
165
assertEquals(elementsToAdd - 1 , builder.last())
163
166
assertEquals(index, builder.first())
164
167
assertEquals(elementsToAdd - index, builder.size)
168
+ // TODO: avoid list allocations using approach from addLastTests
165
169
assertEquals(List (elementsToAdd - index) { it + index }, builder.toList())
166
170
builder.removeAt(0 )
167
171
}
@@ -183,6 +187,7 @@ class PersistentListBuilderTest {
183
187
assertEquals(index, builder.last())
184
188
assertEquals(elementsToAdd - 1 , builder.first())
185
189
assertEquals(elementsToAdd - index, builder.size)
190
+ // TODO: avoid list allocations using approach from addLastTests
186
191
assertEquals(List (elementsToAdd - index) { elementsToAdd - 1 - it }, builder)
187
192
188
193
builder.removeAt(builder.size - 1 )
0 commit comments