Skip to content

Commit a7def44

Browse files
committed
Avoid allocating a lot of expected lists in PersistentListBuilderTest.addLastTests
1 parent 8dd7476 commit a7def44

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

core/commonTest/src/stress/list/PersistentListBuilderTest.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ class PersistentListBuilderTest {
128128
assertEquals(index, builder.first())
129129
assertEquals(0, builder.last())
130130
assertEquals(index + 1, builder.size)
131+
// TODO: avoid list allocations using approach from addLastTests
132+
// TODO: try to avoid n^2
131133
assertEquals(List(index + 1) { index - it }, builder)
132134
}
133135
}
@@ -137,13 +139,14 @@ class PersistentListBuilderTest {
137139
val builder = persistentListOf<Int>().builder()
138140

139141
val elementsToAdd = 10000
142+
val allElements = List(elementsToAdd) { it }
140143
repeat(times = elementsToAdd) { index ->
141144
builder.add(index)
142145

143146
assertEquals(0, builder[0])
144147
assertEquals(index, builder[index])
145148
assertEquals(index + 1, builder.size)
146-
assertEquals(List(index + 1) { it }, builder)
149+
assertEquals(allElements.subList(0, builder.size), builder)
147150
}
148151
}
149152

@@ -162,6 +165,7 @@ class PersistentListBuilderTest {
162165
assertEquals(elementsToAdd - 1, builder.last())
163166
assertEquals(index, builder.first())
164167
assertEquals(elementsToAdd - index, builder.size)
168+
// TODO: avoid list allocations using approach from addLastTests
165169
assertEquals(List(elementsToAdd - index) { it + index }, builder.toList())
166170
builder.removeAt(0)
167171
}
@@ -183,6 +187,7 @@ class PersistentListBuilderTest {
183187
assertEquals(index, builder.last())
184188
assertEquals(elementsToAdd - 1, builder.first())
185189
assertEquals(elementsToAdd - index, builder.size)
190+
// TODO: avoid list allocations using approach from addLastTests
186191
assertEquals(List(elementsToAdd - index) { elementsToAdd - 1 - it }, builder)
187192

188193
builder.removeAt(builder.size - 1)

0 commit comments

Comments
 (0)