Skip to content

Commit 224671b

Browse files
authored
Disable caching on kover artifact tasks
Caching should only be enabled for tasks that do heavy computations and this task does not do so. PR #637
1 parent 85c5881 commit 224671b

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

kover-gradle-plugin/src/functionalTest/kotlin/kotlinx/kover/gradle/plugin/test/functional/cases/BuildCacheRelocationTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class BuildCacheRelocationTests {
5555
val result2 = gradleBuild2.runWithParams("koverXmlReport", "koverHtmlReport", "koverBinaryReport", "koverVerify", "--build-cache", "--info")
5656
try {
5757
assertEquals("FROM-CACHE", result2.taskOutcome(":test"))
58-
assertEquals("FROM-CACHE", result2.taskOutcome(":koverGenerateArtifact"))
58+
assertEquals("SUCCESS", result2.taskOutcome(":koverGenerateArtifact"))
5959
assertEquals("FROM-CACHE", result2.taskOutcome(":koverXmlReport"))
6060
assertEquals("FROM-CACHE", result2.taskOutcome(":koverHtmlReport"))
6161
assertEquals("FROM-CACHE", result2.taskOutcome(":koverBinaryReport"))

kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tasks/services/KoverArtifactGenerationTask.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import org.gradle.api.file.RegularFileProperty
1111
import org.gradle.api.provider.*
1212
import org.gradle.api.tasks.*
1313
import org.gradle.kotlin.dsl.*
14+
import org.gradle.work.DisableCachingByDefault
1415
import java.io.*
1516
import javax.inject.*
1617

@@ -19,7 +20,7 @@ import javax.inject.*
1920
*
2021
* This artifact that will be shared between projects through dependencies for creating merged reports.
2122
*/
22-
@CacheableTask
23+
@DisableCachingByDefault(because = "The task action is so quick that cache does not provide a benefit")
2324
internal abstract class KoverArtifactGenerationTask : DefaultTask() {
2425
@get:InputFiles
2526
@get:PathSensitive(PathSensitivity.RELATIVE)

0 commit comments

Comments
 (0)