Return a Collection instead of List

Author: fzhinkin

core/api/kotlinx-io-core.api

@@ -213,7 +213,7 @@ public abstract interface class kotlinx/io/files/FileSystem {
 	public abstract fun delete (Lkotlinx/io/files/Path;Z)V
 	public static synthetic fun delete$default (Lkotlinx/io/files/FileSystem;Lkotlinx/io/files/Path;ZILjava/lang/Object;)V
 	public abstract fun exists (Lkotlinx/io/files/Path;)Z
-	public abstract fun list (Lkotlinx/io/files/Path;)Ljava/util/List;
+	public abstract fun list (Lkotlinx/io/files/Path;)Ljava/util/Collection;
 	public abstract fun metadataOrNull (Lkotlinx/io/files/Path;)Lkotlinx/io/files/FileMetadata;
 	public abstract fun resolve (Lkotlinx/io/files/Path;)Lkotlinx/io/files/Path;
 	public abstract fun sink (Lkotlinx/io/files/Path;Z)Lkotlinx/io/RawSink;

core/api/kotlinx-io-core.klib.api

@@ -162,7 +162,7 @@ sealed interface kotlinx.io.files/FileSystem { // kotlinx.io.files/FileSystem|nu
     abstract fun createDirectories(kotlinx.io.files/Path, kotlin/Boolean =...) // kotlinx.io.files/FileSystem.createDirectories|createDirectories(kotlinx.io.files.Path;kotlin.Boolean){}[0]
     abstract fun delete(kotlinx.io.files/Path, kotlin/Boolean =...) // kotlinx.io.files/FileSystem.delete|delete(kotlinx.io.files.Path;kotlin.Boolean){}[0]
     abstract fun exists(kotlinx.io.files/Path): kotlin/Boolean // kotlinx.io.files/FileSystem.exists|exists(kotlinx.io.files.Path){}[0]
-    abstract fun list(kotlinx.io.files/Path): kotlin.collections/List<kotlinx.io.files/Path> // kotlinx.io.files/FileSystem.list|list(kotlinx.io.files.Path){}[0]
+    abstract fun list(kotlinx.io.files/Path): kotlin.collections/Collection<kotlinx.io.files/Path> // kotlinx.io.files/FileSystem.list|list(kotlinx.io.files.Path){}[0]
     abstract fun metadataOrNull(kotlinx.io.files/Path): kotlinx.io.files/FileMetadata? // kotlinx.io.files/FileSystem.metadataOrNull|metadataOrNull(kotlinx.io.files.Path){}[0]
     abstract fun resolve(kotlinx.io.files/Path): kotlinx.io.files/Path // kotlinx.io.files/FileSystem.resolve|resolve(kotlinx.io.files.Path){}[0]
     abstract fun sink(kotlinx.io.files/Path, kotlin/Boolean =...): kotlinx.io/RawSink // kotlinx.io.files/FileSystem.sink|sink(kotlinx.io.files.Path;kotlin.Boolean){}[0]

core/common/src/files/FileSystem.kt

@@ -147,22 +147,23 @@ public sealed interface FileSystem {
     public fun resolve(path: Path): Path
 
     /**
-     * Returns a list of paths corresponding to [directory]'s immediate children.
+     * Returns paths corresponding to [directory]'s immediate children.
      *
-     * If path [directory] was an absolute path, a returned list will also contain absolute paths.
-     * If it was a relative path, a returned list will contain relative paths.
+     * There are no guarantees on children paths order within a returned collection.
+     *
+     * If path [directory] was an absolute path, a returned collection will also contain absolute paths.
+     * If it was a relative path, a returned collection will contain relative paths.
      *
      * *For `wasmWasi` target, function does not work with NodeJS runtime on Windows,
      * as `fd_readdir` function is [not implemented there](https://github.com/nodejs/node/blob/6f4d6011ea1b448cf21f5d363c44e4a4c56ca34c/deps/uvwasi/src/uvwasi.c#L19).*
      *
-     *
      * @param directory a directory to list.
-     * @return a list of [directory]'s immediate children.
+     * @return a collection of [directory]'s immediate children.
      * @throws FileNotFoundException if [directory] does not exist.
      * @throws IOException if [directory] points to something other than directory.
      * @throws IOException if there was an underlying error preventing listing [directory] children.
      */
-    public fun list(directory: Path): List<Path>
+    public fun list(directory: Path): Collection<Path>
 }
 
 internal abstract class SystemFileSystemImpl : FileSystem

core/jvm/src/files/FileSystemJvm.kt

@@ -97,7 +97,7 @@ public actual val SystemFileSystem: FileSystem = object : SystemFileSystemImpl()
         return Path(path.file.canonicalFile)
     }
 
-    override fun list(directory: Path): List<Path> {
+    override fun list(directory: Path): Collection<Path> {
         val file = directory.file
         if (!file.exists()) throw FileNotFoundException(file.absolutePath)
         if (!file.isDirectory) throw IOException("Not a directory: ${file.absolutePath}")

core/native/src/files/FileSystemNative.kt

@@ -87,7 +87,7 @@ public actual val SystemFileSystem: FileSystem = object : SystemFileSystemImpl()
         return FileSink(openFile)
     }
 
-    override fun list(directory: Path): List<Path> {
+    override fun list(directory: Path): Collection<Path> {
         val metadata = metadataOrNull(directory) ?: throw FileNotFoundException(directory.path)
         if (!metadata.isDirectory) throw IOException("Not a directory: ${directory.path}")
         return buildList {

core/nodeFilesystemShared/src/files/FileSystemNodeJs.kt

@@ -101,7 +101,7 @@ public actual val SystemFileSystem: FileSystem = object : SystemFileSystemImpl()
         return Path(fs.realpathSync.native(path.path))
     }
 
-    override fun list(directory: Path): List<Path> {
+    override fun list(directory: Path): Collection<Path> {
         val metadata = metadataOrNull(directory) ?: throw FileNotFoundException(directory.path)
         if (!metadata.isDirectory) throw IOException("Not a directory: ${directory.path}")
         val dir = fs.opendirSync(directory.path) ?: throw IOException("Unable to read directory: ${directory.path}")

core/wasmWasi/src/files/FileSystemWasm.kt

@@ -277,7 +277,7 @@ internal object WasiFileSystem : SystemFileSystemImpl() {
         }
     }
 
-    override fun list(directory: Path): List<Path> {
+    override fun list(directory: Path): Collection<Path> {
         val preOpen = PreOpens.findPreopen(directory)
 
         val metadata = metadataOrNullInternal(preOpen.fd, directory, true)