Fix chasing symlinks

Author: dkhalanskyjb

core/nix/src/internal/TzdbOnFilesystem.kt

@@ -50,7 +50,7 @@ private val tzdbPaths = sequence {
 
 // taken from https://github.com/HowardHinnant/date/blob/ab37c362e35267d6dee02cb47760f9e9c669d3be/src/tz.cpp#L3951-L3952
 internal fun pathToSystemDefault(): Pair<Path, Path>? {
-    val info = Path(true, listOf("etc", "localtime")).chaseSymlinks().first
+    val info = Path(true, listOf("etc", "localtime")).chaseSymlinks()
     val i = info.components.indexOf("zoneinfo")
     if (!info.isAbsolute || i == -1 || i == info.components.size - 1) return null
     return Pair(
@@ -60,5 +60,5 @@ internal fun pathToSystemDefault(): Pair<Path, Path>? {
 }
 
 internal actual val systemTzdb: TimezoneDatabase = tzdbPaths.find {
-    it.chaseSymlinks().second?.isDirectory == true
+    it.chaseSymlinks().check()?.isDirectory == true
 }?.let { TzdbOnFilesystem(it) } ?: throw IllegalStateException("Could not find the path to the timezone database")

core/nix/src/internal/filesystem.kt

@@ -53,15 +53,12 @@ internal class Path(val isAbsolute: Boolean, val components: List<String>) {
     }
 }
 
-internal fun Path.chaseSymlinks(): Pair<Path, PathInfo?> {
+internal fun Path.chaseSymlinks(): Path {
     var realPath = this
-    var stat: PathInfo? = realPath.check()
-    while (stat?.isSymlink == true) {
-        stat = null
+    while (true) {
         realPath = realPath.readLink() ?: break
-        stat = realPath.check() ?: break
     }
-    return realPath to stat
+    return realPath
 }
 
 // `stat(2)` lists the other available fields