Skip to content

Commit 8811dcc

Browse files
committed
Update comments for serialVersionUID
1 parent f270838 commit 8811dcc

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

core/jvm/src/LocalDate.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ public actual class LocalDate internal constructor(
5353
public actual fun Format(block: DateTimeFormatBuilder.WithDate.() -> Unit): DateTimeFormat<LocalDate> =
5454
LocalDateFormat.build(block)
5555

56-
// even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
57-
// stable serialVersionUID means exceptions caused by deserialization of malicious streams will be consistent
58-
// (InvalidClassException vs. InvalidObjectException, see MaliciousJvmSerializationTest)
56+
// Even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
57+
// stable serialVersionUID is useful for testing, see MaliciousJvmSerializationTest.
5958
private const val serialVersionUID = 7026816023079564263L
6059
}
6160

core/jvm/src/LocalDateTimeJvm.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,8 @@ public actual class LocalDateTime internal constructor(
107107
public actual fun Format(builder: DateTimeFormatBuilder.WithDateTime.() -> Unit): DateTimeFormat<LocalDateTime> =
108108
LocalDateTimeFormat.build(builder)
109109

110-
// even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
111-
// stable serialVersionUID means exceptions caused by deserialization of malicious streams will be consistent
112-
// (InvalidClassException vs. InvalidObjectException, see MaliciousJvmSerializationTest)
110+
// Even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
111+
// stable serialVersionUID is useful for testing, see MaliciousJvmSerializationTest.
113112
private const val serialVersionUID: Long = -4261744960416354711L
114113
}
115114

core/jvm/src/LocalTimeJvm.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,8 @@ public actual class LocalTime internal constructor(
8686
public actual fun Format(builder: DateTimeFormatBuilder.WithTime.() -> Unit): DateTimeFormat<LocalTime> =
8787
LocalTimeFormat.build(builder)
8888

89-
// even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
90-
// stable serialVersionUID means exceptions caused by deserialization of malicious streams will be consistent
91-
// (InvalidClassException vs. InvalidObjectException, see MaliciousJvmSerializationTest)
89+
// Even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
90+
// stable serialVersionUID is useful for testing, see MaliciousJvmSerializationTest.
9291
private const val serialVersionUID: Long = -352249606036216323L
9392
}
9493

core/jvm/src/UtcOffsetJvm.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,8 @@ public actual class UtcOffset(
4141
public actual fun Format(block: DateTimeFormatBuilder.WithUtcOffset.() -> Unit): DateTimeFormat<UtcOffset> =
4242
UtcOffsetFormat.build(block)
4343

44-
// even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
45-
// stable serialVersionUID means exceptions caused by deserialization of malicious streams will be consistent
46-
// (InvalidClassException vs. InvalidObjectException, see MaliciousJvmSerializationTest)
44+
// Even though this class uses writeReplace (so serialVersionUID is not needed for a stable serialized form), a
45+
// stable serialVersionUID is useful for testing, see MaliciousJvmSerializationTest.
4746
private const val serialVersionUID: Long = -6636773355667981618L
4847
}
4948

0 commit comments

Comments
 (0)