#430: Rename root to systemTimezoneSearchRoot

Author: DmitryNekrasov

core/linux/src/internal/TimeZoneNative.kt

@@ -22,22 +22,22 @@ private val tzdb = runCatching { TzdbOnFilesystem() }
 // See: https://github.com/Kotlin/kotlinx-datetime/issues/430
 @OptIn(ExperimentalForeignApi::class)
 private fun getTimezoneFromEtcTimezone(): String? {
-    val timezoneContent = Path.fromString("${root}etc/timezone").readBytes()?.toKString()?.trim() ?: return null
-    val zoneId = chaseSymlinks("${root}usr/share/zoneinfo/$timezoneContent")
+    val timezoneContent = Path.fromString("${systemTimezoneSearchRoot}etc/timezone").readBytes()?.toKString()?.trim() ?: return null
+    val zoneId = chaseSymlinks("${systemTimezoneSearchRoot}usr/share/zoneinfo/$timezoneContent")
         ?.splitTimeZonePath()?.second?.toString()
         ?: return null
 
-    val zoneInfoBytes = Path.fromString("${root}usr/share/zoneinfo/$zoneId").readBytes() ?: return null
-    val localtimeBytes = Path.fromString("${root}etc/localtime").readBytes() ?: return null
+    val zoneInfoBytes = Path.fromString("${systemTimezoneSearchRoot}usr/share/zoneinfo/$zoneId").readBytes() ?: return null
+    val localtimeBytes = Path.fromString("${systemTimezoneSearchRoot}etc/localtime").readBytes() ?: return null
 
     if (!localtimeBytes.contentEquals(zoneInfoBytes)) {
         val displayTimezone = when (timezoneContent) {
             zoneId -> "'$zoneId'"
             else -> "'$timezoneContent' (resolved to '$zoneId')"
         }
         throw IllegalTimeZoneException(
-            "Timezone mismatch: ${root}etc/timezone specifies $displayTimezone " +
-                    "but ${root}etc/localtime content differs from ${root}usr/share/zoneinfo/$zoneId"
+            "Timezone mismatch: ${systemTimezoneSearchRoot}etc/timezone specifies $displayTimezone " +
+                    "but ${systemTimezoneSearchRoot}etc/localtime content differs from ${systemTimezoneSearchRoot}usr/share/zoneinfo/$zoneId"
         )
     }
 

core/linux/test/TimeZoneNativeTest.kt

@@ -7,7 +7,7 @@ package kotlinx.datetime.test
 
 import kotlinx.datetime.IllegalTimeZoneException
 import kotlinx.datetime.TimeZone
-import kotlinx.datetime.internal.root
+import kotlinx.datetime.internal.systemTimezoneSearchRoot
 import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertFailsWith
@@ -73,12 +73,12 @@ class TimeZoneNativeTest {
         const val RESOURCES = "./linux/test/time-zone-native-test-resources/"
 
         private fun withFakeRoot(fakeRoot: String, action: () -> Unit) {
-            val defaultRoot = root
-            root = fakeRoot
+            val defaultRoot = systemTimezoneSearchRoot
+            systemTimezoneSearchRoot = fakeRoot
             try {
                 action()
             } finally {
-                root = defaultRoot
+                systemTimezoneSearchRoot = defaultRoot
             }
         }
     }

core/tzdbOnFilesystem/src/internal/TzdbOnFilesystem.kt

@@ -47,9 +47,9 @@ internal fun tzdbPaths(defaultTzdbPath: Path?) = sequence {
     currentSystemTimeZonePath?.splitTimeZonePath()?.first?.let { yield(it) }
 }
 
-internal var root: String = "/"
+internal var systemTimezoneSearchRoot: String = "/"
 
-internal val currentSystemTimeZonePath get() = chaseSymlinks("${root}etc/localtime")
+internal val currentSystemTimeZonePath get() = chaseSymlinks("${systemTimezoneSearchRoot}etc/localtime")
 
 /**
  * Given a path like `/usr/share/zoneinfo/Europe/Berlin`, produces `/usr/share/zoneinfo to Europe/Berlin`.