Skip to content

Commit e6d8737

Browse files
riyueguangtshepang
authored andcommitted
chore: fix some comments
Signed-off-by: riyueguang <[email protected]>
1 parent 9a13c75 commit e6d8737

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: src/licenses.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ from.
2020
- The algorithm or code pattern seems like it was likely copied from somewhere else.
2121
- When adding new dependencies, double check the dependency's license.
2222

23-
In all of these cases, we will want to check that source to make sure it it is licensed in a way
23+
In all of these cases, we will want to check that source to make sure it is licensed in a way
2424
that is compatible with Rust’s license.
2525

2626
Examples

Diff for: src/queries/incremental-compilation-in-detail.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ session. The overhead of doing so is a few percent of total compilation time.
529529

530530
Data structures used as query results could be factored in a way that removes
531531
edges from the dependency graph. Especially "span" information is very volatile,
532-
so including it in query result will increase the chance that that result won't
532+
so including it in query result will increase the chance that the result won't
533533
be reusable. See <https://github.com/rust-lang/rust/issues/47389> for more
534534
information.
535535

Diff for: src/ty_module/instantiating_binders.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Given these trait implementations `u32: Bar` should _not_ hold. `&'a u32` only i
7171
- There is a where clause `for<'a> &'^0 T: Trait` on the impl, as we instantiated the early binder with `u32` we actually have to prove `for<'a> &'^0 u32: Trait`
7272
- We find the `impl<T> Trait for T` impl, we would wind up instantiating the `EarlyBinder` with `&'^0 u32`
7373
- There is a where clause `for<'a> T: Other<'^0>`, as we instantiated the early binder with `&'^0 u32` we actually have to prove `for<'a> &'^0 u32: Other<'^0>`
74-
- We find the `impl<'a> Other<'a> for &'a u32` and this impl is enoguh to prove the the bound as the lifetime on the borrow and on the trait are both `'^0`
74+
- We find the `impl<'a> Other<'a> for &'a u32` and this impl is enoguh to prove the bound as the lifetime on the borrow and on the trait are both `'^0`
7575

7676
This end result is incorrect as we had two separate binders introducing their own generic parameters, the trait bound should have ended up as something like `for<'a1, 'a2> &'^1 u32: Other<'^0>` which is _not_ satisfied by the `impl<'a> Other<'a> for &'a u32`.
7777

0 commit comments

Comments
 (0)