Add details to the asyncio connection error message (redis#3211)

For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>

Author: 3 people

tests/test_asyncio/test_connection.py

@@ -494,3 +494,21 @@ async def test_connection_garbage_collection(request):
 
     await client.aclose()
     await pool.aclose()
+
+
+@pytest.mark.parametrize(
+    "error, expected_message",
+    [
+        (OSError(), "Error connecting to localhost:6379. Connection reset by peer"),
+        (OSError(12), "Error connecting to localhost:6379. 12."),
+        (
+            OSError(12, "Some Error"),
+            "Error 12 connecting to localhost:6379. [Errno 12] Some Error.",
+        ),
+    ],
+)
+async def test_connect_error_message(error, expected_message):
+    """Test that the _error_message function formats errors correctly"""
+    conn = Connection()
+    error_message = conn._error_message(error)
+    assert error_message == expected_message

valkey/asyncio/connection.py

@@ -814,7 +814,7 @@ def _error_message(self, exception: BaseException) -> str:
         else:
             return (
                 f"Error {exception.args[0]} connecting to {host_error}. "
-                f"{exception.args[0]}."
+                f"{exception}."
             )