Skip to content

Commit cba7154

Browse files
timofey-soloninSpace Team
authored and
Space Team
committed
[MPP] Remove broken execution test and replace obsolete targets in CommonizerIT with curl
^KT-58822
1 parent d5a0296 commit cba7154

File tree

3 files changed

+15
-42
lines changed
  • libraries/tools/kotlin-gradle-plugin-integration-tests/src/test

3 files changed

+15
-42
lines changed

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/CommonizerIT.kt

Lines changed: 13 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import groovy.json.StringEscapeUtils
99
import org.gradle.api.logging.LogLevel.INFO
1010
import org.gradle.internal.os.OperatingSystem
1111
import org.jetbrains.kotlin.commonizer.CommonizerTarget
12-
import org.jetbrains.kotlin.gradle.testbase.TestVersions
1312
import org.jetbrains.kotlin.gradle.util.reportSourceSetCommonizerDependencies
1413
import org.jetbrains.kotlin.incremental.testingUtils.assertEqualDirectories
1514
import org.jetbrains.kotlin.konan.target.HostManager
@@ -171,33 +170,13 @@ open class CommonizerIT : BaseGradleIT() {
171170
assertSuccessful()
172171
}
173172

174-
if (CommonizableTargets.targetA.isCompilable) {
175-
// targetA will be macos
176-
build(":targetABinaries") {
177-
assertSuccessful()
178-
}
179-
}
180-
if (CommonizableTargets.targetB.isCompilable) {
181-
//targetB will be linuxArm64
182-
build(":targetBBinaries") {
183-
assertSuccessful()
184-
}
185-
}
186-
}
187-
}
188-
189-
@Test
190-
fun `test commonizeCurlInterop execution`() {
191-
with(preparedProject("commonizeCurlInterop")) {
192-
if (CommonizableTargets.targetA.isExecutable) {
193-
build(":targetATest") {
194-
assertSuccessful()
195-
}
173+
// targetA will be macos
174+
build(":compileTestKotlinTargetA") {
175+
assertSuccessful()
196176
}
197-
if (CommonizableTargets.targetB.isExecutable) {
198-
build(":targetBTest") {
199-
assertSuccessful()
200-
}
177+
//targetB will be linuxArm64
178+
build(":compileTestKotlinTargetB") {
179+
assertSuccessful()
201180
}
202181
}
203182
}
@@ -721,24 +700,24 @@ open class CommonizerIT : BaseGradleIT() {
721700
}
722701
}
723702

724-
private data class TargetSubstitution(val value: String, val isCompilable: Boolean, val isExecutable: Boolean) {
703+
private data class TargetSubstitution(val value: String) {
725704
override fun toString(): String = value
726705
}
727706

728707
private object CommonizableTargets {
729708
private val os = OperatingSystem.current()
730709

731710
val targetA = when {
732-
os.isMacOsX -> TargetSubstitution("macosX64", isCompilable = true, isExecutable = true)
733-
os.isLinux -> TargetSubstitution("linuxX64", isCompilable = true, isExecutable = true)
734-
os.isWindows -> TargetSubstitution("mingwX64", isCompilable = true, isExecutable = false)
711+
os.isMacOsX -> TargetSubstitution("macosX64")
712+
os.isLinux -> TargetSubstitution("linuxX64")
713+
os.isWindows -> TargetSubstitution("mingwX64")
735714
else -> fail("Unsupported os: ${os.name}")
736715
}
737716

738717
val targetB = when {
739-
os.isMacOsX -> TargetSubstitution("linuxX64", isCompilable = true, isExecutable = false)
740-
os.isLinux -> TargetSubstitution("linuxArm64", isCompilable = true, isExecutable = false)
741-
os.isWindows -> TargetSubstitution("mingwX86", isCompilable = true, isExecutable = false)
718+
os.isMacOsX -> TargetSubstitution("linuxX64")
719+
os.isLinux -> TargetSubstitution("linuxArm64")
720+
os.isWindows -> TargetSubstitution("linuxX64")
742721
else -> fail("Unsupported os: ${os.name}")
743722
}
744723
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
headers = curl/curl.h
22
headerFilter = curl/*
3-
compilerOpts = -Ilibs/include
4-
5-
linkerOpts.osx = -L/opt/local/lib -L/usr/local/opt/curl/lib -lcurl
6-
linkerOpts.linux = -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 -lcurl
3+
compilerOpts = -Ilibs/include
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
headers = curl/curl.h
22
headerFilter = curl/*
3-
compilerOpts = -Ilibs/include
4-
5-
linkerOpts.osx = -L/opt/local/lib -L/usr/local/opt/curl/lib -lcurl
6-
linkerOpts.linux = -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 -lcurl
3+
compilerOpts = -Ilibs/include

0 commit comments

Comments
 (0)