FIR: remove property delegation in generated error lists

The point of using delegated properties is to avoid duplicating
the name of the diagnostic by using `KProperty.name`, but this is
meaningless when the code is automatically generated in the first
place. Generating the entire call significantly reduces the size
of the class initializer. For example, FirErrors was over 420 KB
with a 58 KB `<clinit>` (dangerously close to JVM's 64 KiB limit);
now it's only 225 KB with a 22 KB `<clinit>`.

Another option is to finally implement more delegated property
optimizations - see KT-16997 - but that'll take a while, and changing
the code generator is easy anyway.

^KT-68829

(cherry picked from commit f83f0e3)

Author: pyos

compiler/fir/checkers/checkers-component-generator/src/org/jetbrains/kotlin/fir/checkers/generator/diagnostics/model/ErrorListDiagnosticListRenderer.kt

@@ -68,30 +68,21 @@ object ErrorListDiagnosticListRenderer : DiagnosticListRenderer() {
     }
 
     private fun SmartPrinter.printDiagnostic(diagnostic: DiagnosticData) {
-        print("val ${diagnostic.name}: ${diagnostic.getPropertType()}")
-        diagnostic.parameters.map { it.type }.ifNotEmpty { printTypeArguments(this) }
-        print(" by ${diagnostic.getFactoryFunction()}")
-        printTypeArguments(diagnostic.getAllTypeArguments())
-        printPositioningStrategyAndLanguageFeature(diagnostic)
-        println()
-    }
-
-    private fun SmartPrinter.printPositioningStrategyAndLanguageFeature(diagnostic: DiagnosticData) {
-        val argumentsList = buildList {
-            if (diagnostic is DeprecationDiagnosticData) {
-                add(diagnostic.featureForError.name)
-            }
-            if (!diagnostic.hasDefaultPositioningStrategy()) {
-                add(diagnostic.positioningStrategy.expressionToCreate)
-            }
+        val type = diagnostic.getProperType()
+        val escapedName = "\"${diagnostic.name}\""
+        val severityOrFeatureForError = when (diagnostic) {
+            is RegularDiagnosticData -> diagnostic.severity.name
+            is DeprecationDiagnosticData -> diagnostic.featureForError.name
         }
-        print(argumentsList.joinToString(", ", prefix = "(", postfix = ")"))
-    }
+        val positioningStrategy = diagnostic.positioningStrategy.expressionToCreate
+        val psiTypeClass = "${diagnostic.psiType.kClass.simpleName!!}::class"
 
-
-    private fun DiagnosticData.getAllTypeArguments(): List<KType> = buildList {
-        add(psiType)
-        parameters.mapTo(this) { it.type }
+        print("val ${diagnostic.name}: $type")
+        diagnostic.parameters.map { it.type }.ifNotEmpty { printTypeArguments(this) }
+        print(" = $type(")
+        printSeparatedWithComma(listOf(escapedName, severityOrFeatureForError, positioningStrategy, psiTypeClass)) { print(it) }
+        print(")")
+        println()
     }
 
     private fun SmartPrinter.printTypeArguments(typeArguments: List<KType>) {
@@ -146,31 +137,29 @@ object ErrorListDiagnosticListRenderer : DiagnosticListRenderer() {
                 add("$starImport.*")
             }
         }
+
         diagnosticList.allDiagnostics.forEach { diagnostic ->
-            for (typeArgument in diagnostic.getAllTypeArguments()) {
-                typeArgument.collectClassNamesTo(this)
+            diagnostic.psiType.collectClassNamesTo(this)
+            for (parameter in diagnostic.parameters) {
+                parameter.type.collectClassNamesTo(this)
             }
-            if (!diagnostic.hasDefaultPositioningStrategy()) {
-                add(PositioningStrategy.importToAdd)
+            add("org.jetbrains.kotlin.diagnostics." + diagnostic.getProperType())
+            when (diagnostic) {
+                is RegularDiagnosticData ->
+                    add("org.jetbrains.kotlin.diagnostics.Severity.${diagnostic.severity.name}")
+                is DeprecationDiagnosticData ->
+                    add("org.jetbrains.kotlin.config.LanguageFeature.${diagnostic.featureForError.name}")
             }
-            add("org.jetbrains.kotlin.diagnostics." + diagnostic.getPropertType())
-        }
-        for (deprecationDiagnostic in diagnosticList.allDiagnostics.filterIsInstance<DeprecationDiagnosticData>()) {
-            add("org.jetbrains.kotlin.config.LanguageFeature.${deprecationDiagnostic.featureForError.name}")
         }
+        add(PositioningStrategy.importToAdd)
         add("org.jetbrains.kotlin.diagnostics.rendering.RootDiagnosticRendererFactory")
     }
 
 
     private val KType.kClass: KClass<*>
         get() = classifier as KClass<*>
 
-    private fun DiagnosticData.getFactoryFunction(): String = when (this) {
-        is RegularDiagnosticData -> severity.name.lowercase()
-        is DeprecationDiagnosticData -> "deprecationError"
-    } + parameters.size
-
-    private fun DiagnosticData.getPropertType(): String = when (this) {
+    private fun DiagnosticData.getProperType(): String = when (this) {
         is RegularDiagnosticData -> "KtDiagnosticFactory"
         is DeprecationDiagnosticData -> "KtDiagnosticFactoryForDeprecation"
     } + parameters.size

compiler/fir/checkers/checkers.js/gen/org/jetbrains/kotlin/fir/analysis/diagnostics/js/FirJsErrors.kt

@@ -12,6 +12,8 @@ import org.jetbrains.kotlin.diagnostics.KtDiagnosticFactory0
 import org.jetbrains.kotlin.diagnostics.KtDiagnosticFactory1
 import org.jetbrains.kotlin.diagnostics.KtDiagnosticFactory2
 import org.jetbrains.kotlin.diagnostics.KtDiagnosticFactoryForDeprecation1
+import org.jetbrains.kotlin.diagnostics.Severity.ERROR
+import org.jetbrains.kotlin.diagnostics.Severity.WARNING
 import org.jetbrains.kotlin.diagnostics.SourceElementPositioningStrategies
 import org.jetbrains.kotlin.diagnostics.rendering.RootDiagnosticRendererFactory
 import org.jetbrains.kotlin.fir.analysis.diagnostics.*
@@ -27,43 +29,43 @@ import org.jetbrains.kotlin.psi.KtElement
  */
 object FirNativeErrors {
     // All
-    val THROWS_LIST_EMPTY: KtDiagnosticFactory0 by error0<KtElement>()
-    val INCOMPATIBLE_THROWS_OVERRIDE: KtDiagnosticFactory1<FirRegularClassSymbol> by error1<KtElement, FirRegularClassSymbol>()
-    val INCOMPATIBLE_THROWS_INHERITED: KtDiagnosticFactory1<Collection<FirRegularClassSymbol>> by error1<KtDeclaration, Collection<FirRegularClassSymbol>>()
-    val MISSING_EXCEPTION_IN_THROWS_ON_SUSPEND: KtDiagnosticFactory1<FqName> by error1<KtElement, FqName>()
-    val INAPPLICABLE_SHARED_IMMUTABLE_PROPERTY: KtDiagnosticFactory0 by error0<KtElement>()
-    val INAPPLICABLE_SHARED_IMMUTABLE_TOP_LEVEL: KtDiagnosticFactory0 by error0<KtElement>()
-    val INAPPLICABLE_THREAD_LOCAL: KtDiagnosticFactory0 by error0<KtElement>()
-    val INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL: KtDiagnosticFactory0 by error0<KtElement>()
-    val INVALID_CHARACTERS_NATIVE: KtDiagnosticFactoryForDeprecation1<String> by deprecationError1<PsiElement, String>(ProhibitInvalidCharsInNativeIdentifiers, SourceElementPositioningStrategies.NAME_IDENTIFIER)
-    val REDUNDANT_SWIFT_REFINEMENT: KtDiagnosticFactory0 by error0<KtElement>()
-    val INCOMPATIBLE_OBJC_REFINEMENT_OVERRIDE: KtDiagnosticFactory2<FirBasedSymbol<*>, Collection<FirRegularClassSymbol>> by error2<KtElement, FirBasedSymbol<*>, Collection<FirRegularClassSymbol>>()
-    val INAPPLICABLE_OBJC_NAME: KtDiagnosticFactory0 by error0<KtElement>()
-    val INVALID_OBJC_NAME: KtDiagnosticFactory0 by error0<KtElement>()
-    val INVALID_OBJC_NAME_CHARS: KtDiagnosticFactory1<String> by error1<KtElement, String>()
-    val INVALID_OBJC_NAME_FIRST_CHAR: KtDiagnosticFactory1<String> by error1<KtElement, String>()
-    val EMPTY_OBJC_NAME: KtDiagnosticFactory0 by error0<KtElement>()
-    val INCOMPATIBLE_OBJC_NAME_OVERRIDE: KtDiagnosticFactory2<FirBasedSymbol<*>, Collection<FirRegularClassSymbol>> by error2<KtElement, FirBasedSymbol<*>, Collection<FirRegularClassSymbol>>()
-    val INAPPLICABLE_EXACT_OBJC_NAME: KtDiagnosticFactory0 by error0<KtElement>()
-    val MISSING_EXACT_OBJC_NAME: KtDiagnosticFactory0 by error0<KtElement>()
-    val NON_LITERAL_OBJC_NAME_ARG: KtDiagnosticFactory0 by error0<KtElement>()
-    val INVALID_OBJC_HIDES_TARGETS: KtDiagnosticFactory0 by error0<KtElement>()
-    val INVALID_REFINES_IN_SWIFT_TARGETS: KtDiagnosticFactory0 by error0<KtElement>()
-    val SUBTYPE_OF_HIDDEN_FROM_OBJC: KtDiagnosticFactory0 by error0<KtElement>()
-    val CANNOT_CHECK_FOR_FORWARD_DECLARATION: KtDiagnosticFactory1<ConeKotlinType> by error1<KtElement, ConeKotlinType>()
-    val UNCHECKED_CAST_TO_FORWARD_DECLARATION: KtDiagnosticFactory2<ConeKotlinType, ConeKotlinType> by warning2<KtElement, ConeKotlinType, ConeKotlinType>()
-    val FORWARD_DECLARATION_AS_REIFIED_TYPE_ARGUMENT: KtDiagnosticFactory1<ConeKotlinType> by error1<KtElement, ConeKotlinType>()
-    val FORWARD_DECLARATION_AS_CLASS_LITERAL: KtDiagnosticFactory1<ConeKotlinType> by error1<KtElement, ConeKotlinType>()
-    val TWO_OR_LESS_PARAMETERS_ARE_SUPPORTED_HERE: KtDiagnosticFactory0 by error0<KtElement>()
-    val PROPERTY_MUST_BE_VAR: KtDiagnosticFactory1<FqName> by error1<KtElement, FqName>()
-    val MUST_NOT_HAVE_EXTENSION_RECEIVER: KtDiagnosticFactory1<String> by error1<KtElement, String>()
-    val MUST_BE_OBJC_OBJECT_TYPE: KtDiagnosticFactory2<String, ConeKotlinType> by error2<KtElement, String, ConeKotlinType>()
-    val MUST_BE_UNIT_TYPE: KtDiagnosticFactory2<String, ConeKotlinType> by error2<KtElement, String, ConeKotlinType>()
-    val CONSTRUCTOR_OVERRIDES_ALREADY_OVERRIDDEN_OBJC_INITIALIZER: KtDiagnosticFactory1<FqName> by error1<KtElement, FqName>()
-    val CONSTRUCTOR_DOES_NOT_OVERRIDE_ANY_SUPER_CONSTRUCTOR: KtDiagnosticFactory1<FqName> by error1<KtElement, FqName>()
-    val CONSTRUCTOR_MATCHES_SEVERAL_SUPER_CONSTRUCTORS: KtDiagnosticFactory1<FqName> by error1<KtElement, FqName>()
-    val CONFLICTING_OBJC_OVERLOADS: KtDiagnosticFactory1<Collection<FirBasedSymbol<*>>> by error1<PsiElement, Collection<FirBasedSymbol<*>>>()
-    val INAPPLICABLE_OBJC_OVERRIDE: KtDiagnosticFactory0 by error0<PsiElement>()
+    val THROWS_LIST_EMPTY: KtDiagnosticFactory0 = KtDiagnosticFactory0("THROWS_LIST_EMPTY", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INCOMPATIBLE_THROWS_OVERRIDE: KtDiagnosticFactory1<FirRegularClassSymbol> = KtDiagnosticFactory1("INCOMPATIBLE_THROWS_OVERRIDE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INCOMPATIBLE_THROWS_INHERITED: KtDiagnosticFactory1<Collection<FirRegularClassSymbol>> = KtDiagnosticFactory1("INCOMPATIBLE_THROWS_INHERITED", ERROR, SourceElementPositioningStrategies.DEFAULT, KtDeclaration::class)
+    val MISSING_EXCEPTION_IN_THROWS_ON_SUSPEND: KtDiagnosticFactory1<FqName> = KtDiagnosticFactory1("MISSING_EXCEPTION_IN_THROWS_ON_SUSPEND", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_SHARED_IMMUTABLE_PROPERTY: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_SHARED_IMMUTABLE_PROPERTY", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_SHARED_IMMUTABLE_TOP_LEVEL: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_SHARED_IMMUTABLE_TOP_LEVEL", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_THREAD_LOCAL: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_THREAD_LOCAL", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_CHARACTERS_NATIVE: KtDiagnosticFactoryForDeprecation1<String> = KtDiagnosticFactoryForDeprecation1("INVALID_CHARACTERS_NATIVE", ProhibitInvalidCharsInNativeIdentifiers, SourceElementPositioningStrategies.NAME_IDENTIFIER, PsiElement::class)
+    val REDUNDANT_SWIFT_REFINEMENT: KtDiagnosticFactory0 = KtDiagnosticFactory0("REDUNDANT_SWIFT_REFINEMENT", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INCOMPATIBLE_OBJC_REFINEMENT_OVERRIDE: KtDiagnosticFactory2<FirBasedSymbol<*>, Collection<FirRegularClassSymbol>> = KtDiagnosticFactory2("INCOMPATIBLE_OBJC_REFINEMENT_OVERRIDE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_OBJC_NAME: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_OBJC_NAME", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_OBJC_NAME: KtDiagnosticFactory0 = KtDiagnosticFactory0("INVALID_OBJC_NAME", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_OBJC_NAME_CHARS: KtDiagnosticFactory1<String> = KtDiagnosticFactory1("INVALID_OBJC_NAME_CHARS", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_OBJC_NAME_FIRST_CHAR: KtDiagnosticFactory1<String> = KtDiagnosticFactory1("INVALID_OBJC_NAME_FIRST_CHAR", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val EMPTY_OBJC_NAME: KtDiagnosticFactory0 = KtDiagnosticFactory0("EMPTY_OBJC_NAME", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INCOMPATIBLE_OBJC_NAME_OVERRIDE: KtDiagnosticFactory2<FirBasedSymbol<*>, Collection<FirRegularClassSymbol>> = KtDiagnosticFactory2("INCOMPATIBLE_OBJC_NAME_OVERRIDE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INAPPLICABLE_EXACT_OBJC_NAME: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_EXACT_OBJC_NAME", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val MISSING_EXACT_OBJC_NAME: KtDiagnosticFactory0 = KtDiagnosticFactory0("MISSING_EXACT_OBJC_NAME", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val NON_LITERAL_OBJC_NAME_ARG: KtDiagnosticFactory0 = KtDiagnosticFactory0("NON_LITERAL_OBJC_NAME_ARG", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_OBJC_HIDES_TARGETS: KtDiagnosticFactory0 = KtDiagnosticFactory0("INVALID_OBJC_HIDES_TARGETS", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val INVALID_REFINES_IN_SWIFT_TARGETS: KtDiagnosticFactory0 = KtDiagnosticFactory0("INVALID_REFINES_IN_SWIFT_TARGETS", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val SUBTYPE_OF_HIDDEN_FROM_OBJC: KtDiagnosticFactory0 = KtDiagnosticFactory0("SUBTYPE_OF_HIDDEN_FROM_OBJC", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val CANNOT_CHECK_FOR_FORWARD_DECLARATION: KtDiagnosticFactory1<ConeKotlinType> = KtDiagnosticFactory1("CANNOT_CHECK_FOR_FORWARD_DECLARATION", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val UNCHECKED_CAST_TO_FORWARD_DECLARATION: KtDiagnosticFactory2<ConeKotlinType, ConeKotlinType> = KtDiagnosticFactory2("UNCHECKED_CAST_TO_FORWARD_DECLARATION", WARNING, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val FORWARD_DECLARATION_AS_REIFIED_TYPE_ARGUMENT: KtDiagnosticFactory1<ConeKotlinType> = KtDiagnosticFactory1("FORWARD_DECLARATION_AS_REIFIED_TYPE_ARGUMENT", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val FORWARD_DECLARATION_AS_CLASS_LITERAL: KtDiagnosticFactory1<ConeKotlinType> = KtDiagnosticFactory1("FORWARD_DECLARATION_AS_CLASS_LITERAL", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val TWO_OR_LESS_PARAMETERS_ARE_SUPPORTED_HERE: KtDiagnosticFactory0 = KtDiagnosticFactory0("TWO_OR_LESS_PARAMETERS_ARE_SUPPORTED_HERE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val PROPERTY_MUST_BE_VAR: KtDiagnosticFactory1<FqName> = KtDiagnosticFactory1("PROPERTY_MUST_BE_VAR", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val MUST_NOT_HAVE_EXTENSION_RECEIVER: KtDiagnosticFactory1<String> = KtDiagnosticFactory1("MUST_NOT_HAVE_EXTENSION_RECEIVER", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val MUST_BE_OBJC_OBJECT_TYPE: KtDiagnosticFactory2<String, ConeKotlinType> = KtDiagnosticFactory2("MUST_BE_OBJC_OBJECT_TYPE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val MUST_BE_UNIT_TYPE: KtDiagnosticFactory2<String, ConeKotlinType> = KtDiagnosticFactory2("MUST_BE_UNIT_TYPE", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val CONSTRUCTOR_OVERRIDES_ALREADY_OVERRIDDEN_OBJC_INITIALIZER: KtDiagnosticFactory1<FqName> = KtDiagnosticFactory1("CONSTRUCTOR_OVERRIDES_ALREADY_OVERRIDDEN_OBJC_INITIALIZER", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val CONSTRUCTOR_DOES_NOT_OVERRIDE_ANY_SUPER_CONSTRUCTOR: KtDiagnosticFactory1<FqName> = KtDiagnosticFactory1("CONSTRUCTOR_DOES_NOT_OVERRIDE_ANY_SUPER_CONSTRUCTOR", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val CONSTRUCTOR_MATCHES_SEVERAL_SUPER_CONSTRUCTORS: KtDiagnosticFactory1<FqName> = KtDiagnosticFactory1("CONSTRUCTOR_MATCHES_SEVERAL_SUPER_CONSTRUCTORS", ERROR, SourceElementPositioningStrategies.DEFAULT, KtElement::class)
+    val CONFLICTING_OBJC_OVERLOADS: KtDiagnosticFactory1<Collection<FirBasedSymbol<*>>> = KtDiagnosticFactory1("CONFLICTING_OBJC_OVERLOADS", ERROR, SourceElementPositioningStrategies.DEFAULT, PsiElement::class)
+    val INAPPLICABLE_OBJC_OVERRIDE: KtDiagnosticFactory0 = KtDiagnosticFactory0("INAPPLICABLE_OBJC_OVERRIDE", ERROR, SourceElementPositioningStrategies.DEFAULT, PsiElement::class)
 
     init {
         RootDiagnosticRendererFactory.registerFactory(FirNativeErrorsDefaultMessages)