To avoid memory leaks, don't store list cell renderer in a static field (IDEA-239692)

GitOrigin-RevId: 2035e43bdb2372aff4d43834b2db3f763fc2decb

Author: yole

platform/lang-impl/src/com/intellij/ide/actions/newclass/CreateWithTemplatesDialogPanel.java

@@ -17,7 +17,7 @@
 public class CreateWithTemplatesDialogPanel extends NewItemWithTemplatesPopupPanel<Trinity<String, Icon, String>> {
 
   public CreateWithTemplatesDialogPanel(@NotNull List<Trinity<String, Icon, String>> templates, @Nullable String selectedItem) {
-    super(templates, LIST_RENDERER);
+    super(templates, new TemplateListCellRenderer());
     myTemplatesList.addListSelectionListener(e -> {
       Trinity<String, Icon, String> selectedValue = myTemplatesList.getSelectedValue();
       if (selectedValue != null) {
@@ -63,28 +63,26 @@ private void selectTemplate(@Nullable String selectedItem) {
     }
   }
 
-  private static final ListCellRenderer<Trinity<String, Icon, String>> LIST_RENDERER =
-    new ListCellRenderer<Trinity<String, Icon, String>>() {
-
-      private final ListCellRenderer<Trinity<String, Icon, String>> delegateRenderer =
-        SimpleListCellRenderer.create((label, value, index) -> {
-          if (value != null) {
-            label.setText(value.first);
-            label.setIcon(value.second);
-          }
-        });
-
-      @Override
-      public Component getListCellRendererComponent(JList<? extends Trinity<String, Icon, String>> list,
-                                                    Trinity<String, Icon, String> value,
-                                                    int index,
-                                                    boolean isSelected,
-                                                    boolean cellHasFocus) {
-        JComponent delegate = (JComponent) delegateRenderer.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
-        delegate.setBorder(JBUI.Borders.empty(JBUIScale.scale(3), JBUIScale.scale(1)));
-        return delegate;
-      }
-    };
+  private static class TemplateListCellRenderer implements ListCellRenderer<Trinity<String, Icon, String>> {
+    private final ListCellRenderer<Trinity<String, Icon, String>> delegateRenderer =
+      SimpleListCellRenderer.create((label, value, index) -> {
+        if (value != null) {
+          label.setText(value.first);
+          label.setIcon(value.second);
+        }
+      });
+
+    @Override
+    public Component getListCellRendererComponent(JList<? extends Trinity<String, Icon, String>> list,
+                                                  Trinity<String, Icon, String> value,
+                                                  int index,
+                                                  boolean isSelected,
+                                                  boolean cellHasFocus) {
+      JComponent delegate = (JComponent) delegateRenderer.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
+      delegate.setBorder(JBUI.Borders.empty(JBUIScale.scale(3), JBUIScale.scale(1)));
+      return delegate;
+    }
+  }
 
   private static class TemplateIconExtension implements ExtendableTextComponent.Extension {
     private final Icon icon;
@@ -101,4 +99,5 @@ public boolean isIconBeforeText() {
       return true;
     }
   }
+
 }