Skip to content

Commit 2567aea

Browse files
committed
Remove unused arguments from mve_Init()
Before this change, mve_Init() took two arguments. Neither of the arguments were ever used. This commit simplifies some code by removing those unused arguments. The main motivation behind this commit is to make it easier to make a future commit. One of the arguments that this commit removes was named dir. dir was a path to the movies/ directory. The future commit will make it so that there can be more than one movies/ directory. Removing dir means that I won’t have to mess with dir when I create that future commit.
1 parent c14bb1d commit 2567aea

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

Descent3/cinematics.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,7 @@ bool InitCinematics() {
4444
return true;
4545
}
4646

47-
char path[_MAX_PATH];
48-
ddio_MakePath(path, Base_directory, "movies", NULL);
49-
50-
if (mve_Init(path, Sound_card_name) != MVELIB_NOERROR)
47+
if (mve_Init() != MVELIB_NOERROR)
5148
return false;
5249

5350
mve_SetCallback(CinematicCallback);

Descent3/d3movie.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ static bool mve_InitSound();
5454
static void mve_CloseSound();
5555
#endif
5656

57-
// sets the directory where movies are stored
58-
int mve_Init(const char *dir, const char *sndcard) {
57+
int mve_Init() {
5958
#ifndef NO_MOVIES
6059
return MVELIB_NOERROR;
6160
#else

Descent3/d3movie.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#define MVELIB_PLAYBACK_ERROR (-5)
3434
#define MVELIB_PLAYBACK_ABORTED (-6)
3535

36-
int mve_Init(const char *dir, const char *sndcard);
36+
int mve_Init();
3737

3838
// simply plays a movie.
3939
int mve_PlayMovie(const std::filesystem::path &pMovieName, oeApplication *pApp);

0 commit comments

Comments
 (0)