Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

Commit 8e70375

Browse files
authored
test: ast alignment tests did not account for javascript rename (#36)
1 parent 833f218 commit 8e70375

File tree

2 files changed

+50
-59
lines changed

2 files changed

+50
-59
lines changed

tests/ast-alignment/fixtures-to-test.ts

+46-59
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,11 @@ let fixturePatternConfigsToTest = [
113113
]
114114
}),
115115

116-
createFixturePatternConfigFor('ecma-features/templateStrings', {
116+
createFixturePatternConfigFor('javascript/templateStrings', {
117117
ignore: ['**/*']
118118
}),
119119

120-
createFixturePatternConfigFor('ecma-features/experimentalObjectRestSpread', {
120+
createFixturePatternConfigFor('javascript/experimentalObjectRestSpread', {
121121
ignore: [
122122
/**
123123
* Trailing comma is not permitted after a "RestElement" in Babylon
@@ -126,7 +126,7 @@ let fixturePatternConfigsToTest = [
126126
]
127127
}),
128128

129-
createFixturePatternConfigFor('ecma-features/arrowFunctions', {
129+
createFixturePatternConfigFor('javascript/arrowFunctions', {
130130
ignore: [
131131
/**
132132
* Expected babylon parse errors - all of these files below produce parse errors in espree
@@ -141,10 +141,10 @@ let fixturePatternConfigsToTest = [
141141
]
142142
}),
143143

144-
createFixturePatternConfigFor('ecma-features/binaryLiterals'),
145-
createFixturePatternConfigFor('ecma-features/blockBindings'),
144+
createFixturePatternConfigFor('javascript/binaryLiterals'),
145+
createFixturePatternConfigFor('javascript/blockBindings'),
146146

147-
createFixturePatternConfigFor('ecma-features/classes', {
147+
createFixturePatternConfigFor('javascript/classes', {
148148
ignore: [
149149
/**
150150
* super() is being used outside of constructor. Other parsers (e.g. espree, acorn) do not error on this.
@@ -160,9 +160,9 @@ let fixturePatternConfigsToTest = [
160160
]
161161
}),
162162

163-
createFixturePatternConfigFor('ecma-features/defaultParams'),
163+
createFixturePatternConfigFor('javascript/defaultParams'),
164164

165-
createFixturePatternConfigFor('ecma-features/destructuring', {
165+
createFixturePatternConfigFor('javascript/destructuring', {
166166
ignore: [
167167
/**
168168
* Expected babylon parse errors - all of these files below produce parse errors in espree
@@ -173,18 +173,12 @@ let fixturePatternConfigsToTest = [
173173
]
174174
}),
175175

176-
createFixturePatternConfigFor(
177-
'ecma-features/destructuring-and-arrowFunctions'
178-
),
179-
createFixturePatternConfigFor(
180-
'ecma-features/destructuring-and-blockBindings'
181-
),
182-
createFixturePatternConfigFor(
183-
'ecma-features/destructuring-and-defaultParams'
184-
),
185-
createFixturePatternConfigFor('ecma-features/destructuring-and-forOf'),
186-
187-
createFixturePatternConfigFor('ecma-features/destructuring-and-spread', {
176+
createFixturePatternConfigFor('javascript/destructuring-and-arrowFunctions'),
177+
createFixturePatternConfigFor('javascript/destructuring-and-blockBindings'),
178+
createFixturePatternConfigFor('javascript/destructuring-and-defaultParams'),
179+
createFixturePatternConfigFor('javascript/destructuring-and-forOf'),
180+
181+
createFixturePatternConfigFor('javascript/destructuring-and-spread', {
188182
ignore: [
189183
/**
190184
* Expected babylon parse errors - all of these files below produce parse errors in espree
@@ -195,11 +189,11 @@ let fixturePatternConfigsToTest = [
195189
]
196190
}),
197191

198-
createFixturePatternConfigFor('ecma-features/experimentalAsyncIteration'),
199-
createFixturePatternConfigFor('ecma-features/experimentalDynamicImport'),
200-
createFixturePatternConfigFor('ecma-features/exponentiationOperators'),
192+
createFixturePatternConfigFor('javascript/experimentalAsyncIteration'),
193+
createFixturePatternConfigFor('javascript/experimentalDynamicImport'),
194+
createFixturePatternConfigFor('javascript/exponentiationOperators'),
201195

202-
createFixturePatternConfigFor('ecma-features/forOf', {
196+
createFixturePatternConfigFor('javascript/forOf', {
203197
ignore: [
204198
/**
205199
* TypeScript, espree and acorn parse this fine - esprima, flow and babylon do not...
@@ -208,10 +202,10 @@ let fixturePatternConfigsToTest = [
208202
]
209203
}),
210204

211-
createFixturePatternConfigFor('ecma-features/generators'),
212-
createFixturePatternConfigFor('ecma-features/globalReturn'),
205+
createFixturePatternConfigFor('javascript/generators'),
206+
createFixturePatternConfigFor('javascript/globalReturn'),
213207

214-
createFixturePatternConfigFor('ecma-features/modules', {
208+
createFixturePatternConfigFor('javascript/modules', {
215209
ignore: [
216210
/**
217211
* TypeScript, flow and babylon parse this fine - esprima, espree and acorn do not...
@@ -282,7 +276,7 @@ let fixturePatternConfigsToTest = [
282276
]
283277
}),
284278

285-
createFixturePatternConfigFor('ecma-features/newTarget', {
279+
createFixturePatternConfigFor('javascript/newTarget', {
286280
ignore: [
287281
/**
288282
* Expected babylon parse errors - all of these files below produce parse errors in espree
@@ -294,35 +288,28 @@ let fixturePatternConfigsToTest = [
294288
]
295289
}),
296290

297-
createFixturePatternConfigFor(
298-
'ecma-features/objectLiteralComputedProperties'
299-
),
300-
301-
createFixturePatternConfigFor(
302-
'ecma-features/objectLiteralDuplicateProperties',
303-
{
304-
ignore: [
305-
/**
306-
* Expected babylon parse errors - all of these files below produce parse errors in espree
307-
* as well, but the TypeScript compiler is so forgiving during parsing that typescript-estree
308-
* does not actually error on them and will produce an AST.
309-
*/
310-
'error-proto-property', // babylon parse errors
311-
'error-proto-string-property' // babylon parse errors
312-
]
313-
}
314-
),
315-
316-
createFixturePatternConfigFor('ecma-features/objectLiteralShorthandMethods'),
317-
createFixturePatternConfigFor(
318-
'ecma-features/objectLiteralShorthandProperties'
319-
),
320-
createFixturePatternConfigFor('ecma-features/octalLiterals'),
321-
createFixturePatternConfigFor('ecma-features/regex'),
322-
createFixturePatternConfigFor('ecma-features/regexUFlag'),
323-
createFixturePatternConfigFor('ecma-features/regexYFlag'),
324-
325-
createFixturePatternConfigFor('ecma-features/restParams', {
291+
createFixturePatternConfigFor('javascript/objectLiteralComputedProperties'),
292+
293+
createFixturePatternConfigFor('javascript/objectLiteralDuplicateProperties', {
294+
ignore: [
295+
/**
296+
* Expected babylon parse errors - all of these files below produce parse errors in espree
297+
* as well, but the TypeScript compiler is so forgiving during parsing that typescript-estree
298+
* does not actually error on them and will produce an AST.
299+
*/
300+
'error-proto-property', // babylon parse errors
301+
'error-proto-string-property' // babylon parse errors
302+
]
303+
}),
304+
305+
createFixturePatternConfigFor('javascript/objectLiteralShorthandMethods'),
306+
createFixturePatternConfigFor('javascript/objectLiteralShorthandProperties'),
307+
createFixturePatternConfigFor('javascript/octalLiterals'),
308+
createFixturePatternConfigFor('javascript/regex'),
309+
createFixturePatternConfigFor('javascript/regexUFlag'),
310+
createFixturePatternConfigFor('javascript/regexYFlag'),
311+
312+
createFixturePatternConfigFor('javascript/restParams', {
326313
ignore: [
327314
/**
328315
* Expected babylon parse errors - all of these files below produce parse errors in espree
@@ -334,8 +321,8 @@ let fixturePatternConfigsToTest = [
334321
]
335322
}),
336323

337-
createFixturePatternConfigFor('ecma-features/spread'),
338-
createFixturePatternConfigFor('ecma-features/unicodeCodePointEscapes'),
324+
createFixturePatternConfigFor('javascript/spread'),
325+
createFixturePatternConfigFor('javascript/unicodeCodePointEscapes'),
339326
createFixturePatternConfigFor('jsx', { ignore: jsxFilesWithKnownIssues }),
340327
createFixturePatternConfigFor('jsx-useJSXTextNode'),
341328

yarn.lock

+4
Original file line numberDiff line numberDiff line change
@@ -847,6 +847,10 @@
847847
version "10.12.2"
848848
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.2.tgz#d77f9faa027cadad9c912cd47f4f8b07b0fb0864"
849849

850+
"@types/node@^10.12.2":
851+
version "10.12.10"
852+
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.12.10.tgz#4fa76e6598b7de3f0cb6ec3abacc4f59e5b3a2ce"
853+
850854
"@types/semver@^5.5.0":
851855
version "5.5.0"
852856
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-5.5.0.tgz#146c2a29ee7d3bae4bf2fcb274636e264c813c45"

0 commit comments

Comments
 (0)