Skip to content

Commit ad5b05a

Browse files
authored
Merge pull request #268 from adrianocola/master
Fixes no-raw-text rule for components with props
2 parents 886999a + 5c70c33 commit ad5b05a

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

lib/rules/no-raw-text.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,10 @@ const elementName = (node, scope) => {
1414
JSXOpeningElement({ node: element }) {
1515
traverse(element, {
1616
JSXIdentifier({ node: identifier }) {
17-
identifiers.push(identifier.name);
17+
if (identifier.parent.type === 'JSXOpeningElement'
18+
|| identifier.parent.type === 'JSXMemberExpression') {
19+
identifiers.push(identifier.name);
20+
}
1821
},
1922
}, scope);
2023
},

tests/lib/rules/no-raw-text.js

+9
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,15 @@ const tests = {
105105
`,
106106
options: [{ skip: ['Title.Text'] }],
107107
},
108+
{
109+
code: `
110+
export default class MyComponent extends Component {
111+
render() {
112+
return (<View><Text style={{color: 'red'}}>some text</Text></View>);
113+
}
114+
}
115+
`,
116+
},
108117
],
109118
invalid: [
110119
{

0 commit comments

Comments
 (0)