Merge pull request #3371 from richardscholtens/fix_issue_#3370_hypothesis

Author: Zac-HD

AUTHORS.rst

@@ -32,6 +32,7 @@ their individual contributions.
 * `Chase Garner <https://www.github.com/chasegarner>`_ ([email protected])
 * `Cheuk Ting Ho <https://github.com/Cheukting>`_
 * `Chris Down  <https://chrisdown.name>`_
+* `Chris van Dronkelaar <https://github.com/Chrisvandr>`_
 * `Christopher Martin <https://www.github.com/chris-martin>`_ ([email protected])
 * `Claudio Jolowicz <https://github.com/cjolowicz>`_
 * `Conrad Ho <https://www.github.com/conradho>`_ ([email protected])
@@ -126,6 +127,7 @@ their individual contributions.
 * `Pierre-Jean Campigotto <https://github.com/PJCampi>`_
 * `Przemek Konopko <https://github.com/soutys>`_
 * `Richard Boulton <https://www.github.com/rboulton>`_ ([email protected])
+* `Richard Scholtens <https://github.com/richardscholtens>`_ ([email protected])
 * `Robert Howlett <https://github.com/jebob>`_
 * `Robert Knight <https://github.com/robertknight>`_ ([email protected])
 * `Rónán Carrigan <https://www.github.com/rcarriga>`_ ([email protected])
@@ -138,6 +140,7 @@ their individual contributions.
 * `Sangarshanan <https://www.github.com/sangarshanan>`_ ([email protected])
 * `Sanyam Khurana <https://github.com/CuriousLearner>`_
 * `Saul Shanabrook <https://www.github.com/saulshanabrook>`_ ([email protected])
+* `Sebastiaan Zeeff <https://github.com/SebastiaanZ>`_ ([email protected])
 * `Shlok Gandhi <https://github.com/shlok57>`_ ([email protected])
 * `Sogata Ray <https://github.com/rayardinanda>`_ ([email protected])
 * `Stuart Cook <https://www.github.com/Zalathar>`_
@@ -155,6 +158,7 @@ their individual contributions.
 * `Tyler Nickerson <https://www.github.com/nmbrgts>`_
 * `Vidya Rani <https://www.github.com/vidyarani-dg>`_ ([email protected])
 * `Vincent Michel <https://www.github.com/vxgmichel>`_ ([email protected])
+* `Viorel Pluta <https://github.com/viopl>`_ ([email protected])
 * `Vytautas Strimaitis <https://www.github.com/vstrimaitis>`_
 * `Will Hall <https://www.github.com/wrhall>`_ ([email protected])
 * `Will Thompson <https://www.github.com/wjt>`_ ([email protected])

hypothesis-python/RELEASE.rst

@@ -0,0 +1,6 @@
+RELEASE_TYPE: patch
+
+Our pretty-printer no longer sorts dictionary keys, since iteration order is
+stable in Python 3.7+ and this can affect reproducing examples (:issue:`3370`).
+This PR was kindly supported by `Ordina Pythoneers
+<https://www.ordina.nl/vakgebieden/python/>`__.

hypothesis-python/src/hypothesis/vendor/pretty.py

@@ -603,16 +603,7 @@ def inner(obj, p, cycle):
         if cycle:
             return p.text("{...}")
         p.begin_group(1, start)
-        keys = obj.keys()
-        # if dict isn't large enough to be truncated, sort keys before
-        # displaying
-        if not (p.max_seq_length and len(obj) >= p.max_seq_length):
-            try:
-                keys = sorted(keys)
-            except Exception:
-                # Sometimes the keys don't sort.
-                pass
-        for idx, key in p._enumerate(keys):
+        for idx, key in p._enumerate(obj):
             if idx:
                 p.text(",")
                 p.breakable()

hypothesis-python/tests/cover/test_pretty.py

@@ -134,6 +134,7 @@ def test_list():
 def test_dict():
     assert pretty.pretty({}) == "{}"
     assert pretty.pretty({1: 1}) == "{1: 1}"
+    assert pretty.pretty({1: 1, 0: 0}) == "{1: 1, 0: 0}"
 
 
 def test_tuple():