Merge pull request #4331 from tybug/fix-healthcheck-link

Add settings redirect and update health check link

Author: Zac-HD

hypothesis-python/RELEASE.rst

@@ -0,0 +1,3 @@
+RELEASE_TYPE: patch
+
+Update the documentation link in |HealthCheck| error messages to their new location in the documentation.

hypothesis-python/docs/conf.py

@@ -55,6 +55,7 @@
     "django": "reference/strategies.html#django",
     "numpy": "reference/strategies.html#numpy",
     "observability": "reference/integrations.html#observability",
+    "settings": "reference/api.html#settings",
     # TODO enable when we actually rename them
     # "extras": "extensions.html",
     # "supported": "compatibility.html",

hypothesis-python/docs/redirect.html.template

@@ -29,7 +29,10 @@
       if (redirect) {
         window.location.replace(redirect);
       } else if (window.location.hash) {
-        window.location.replace(target + window.location.hash);
+        // if both the requested url and the redirect target have a hash, prefer the requested url hash.
+        // This makes a redirect config of {"settings": "api.html#settings"} redirect settings.html#health-checks
+        // to api.html#health-checks instead of api.html#settings.
+        window.location.replace(target.split('#')[0] + window.location.hash);
       } else {
         window.location.replace(target);
       }

hypothesis-python/src/hypothesis/internal/healthcheck.py

@@ -19,8 +19,9 @@ def fail_health_check(settings, message, label):
     if label in settings.suppress_health_check:
         return
     message += (
-        "\nSee https://hypothesis.readthedocs.io/en/latest/health"
-        "checks.html for more information about this. "
+        "\nSee "
+        "https://hypothesis.readthedocs.io/en/latest/reference/api.html#health-checks "
+        "for more information about this. "
         f"If you want to disable just this health check, add {label} "
         "to the suppress_health_check settings for this test."
     )

website/content/2018-01-08-smarkets.md

@@ -131,7 +131,7 @@ hypothesis.errors.FailedHealthCheck: It looks like your strategy is filtering ou
 0 good ones. This will make your tests much slower, and also will probably distort the data generation quite a lot. You should adapt your strategy
  to filter less. This can also be caused by a low max_leaves parameter in recursive() calls.
 
-See https://hypothesis.readthedocs.io/en/latest/healthchecks.html for more information about this. If you want to disable just this health check,
+See https://hypothesis.readthedocs.io/en/latest/reference/api.html#health-checks for more information about this. If you want to disable just this health check,
 add HealthCheck.filter_too_much to the suppress_health_check settings for this test.
 ```