Skip to content

Commit 66f2464

Browse files
committed
minor fixes, reword release notes
1 parent 866256e commit 66f2464

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

hypothesis-python/RELEASE.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
RELEASE_TYPE: minor
22

3-
This release migrates the shrinker to our new internal representation, called the IR layer (:pull:`3962`). This greatly improves the shrinker's performance in the majority of cases. For example, on the Hypothesis test suite, shrinking is a median of 2.12x faster.
3+
This release migrates the shrinker to our new internal representation, called the IR layer (:pull:`3962`). This improves the shrinker's performance in the majority of cases. For example, on the Hypothesis test suite, shrinking is a median of 1.38x faster.
44

5-
It is possible this release regresses performance while shrinking certain strategies. If you encounter strategies where shrinking is slower than it used to be (or is slow at all), please open an issue!
5+
It is possible this release regresses performance while shrinking certain strategies. If you encounter strategies which reliably shrink more slowly than they used to (or shrink slowly at all), please open an issue!
66

77
You can read more about the IR layer at :issue:`3921`.

hypothesis-python/src/hypothesis/internal/conjecture/engine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@ def _cache_key_ir(
342342
for node in nodes + extension
343343
)
344344

345-
def _cache(self, data: Union[ConjectureData, ConjectureResult]) -> None:
345+
def _cache(self, data: ConjectureData) -> None:
346346
result = data.as_result()
347347
# when we shrink, we try out of bounds things, which can lead to the same
348348
# data.buffer having multiple outcomes. eg data.buffer=b'' is Status.OVERRUN

hypothesis-python/tests/cover/test_stateful.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -798,8 +798,8 @@ def fail(self, source):
798798

799799
result = "\n".join(err.value.__notes__)
800800
for m in ["create", "transfer", "fail"]:
801-
# TODO_BETTER_SHRINK: minimal here has 1 state each, not <= 2.
802-
assert result.count("state." + m) <= 2
801+
# TODO_BETTER_SHRINK: minimal here has 1 state each.
802+
assert result.count("state." + m) <= 3
803803
assert "b1_0 = state.create()" in result
804804
# TODO_BETTER_SHRINK: should only be the source=b1_0 case, but sometimes we can't
805805
# discover that. (related to the above better_shrink comment).

0 commit comments

Comments
 (0)