avoid nested-given helpers on crosshair

Author: Zac-HD

hypothesis-python/tests/common/debug.py

@@ -8,7 +8,10 @@
 # v. 2.0. If a copy of the MPL was not distributed with this file, You can
 # obtain one at https://mozilla.org/MPL/2.0/.
 
+from unittest import SkipTest
+
 from hypothesis import HealthCheck, Phase, Verbosity, given, settings as Settings
+from hypothesis.control import _current_build_context
 from hypothesis.errors import Found, NoSuchExample, Unsatisfiable
 from hypothesis.internal.reflection import get_pretty_function_description
 
@@ -26,6 +29,11 @@ def minimal(definition, condition=lambda x: True, settings=None, timeout_after=1
     runtime = None
     result = None
 
+    if (
+        context := _current_build_context.value
+    ) and context.data.provider.avoid_realization:
+        raise SkipTest("`minimal()` helper not supported under symbolic execution")
+
     def wrapped_condition(x):
         nonlocal runtime
         if timeout_after is not None:
@@ -71,6 +79,13 @@ def inner(x):
 
 
 def find_any(definition, condition=lambda _: True, settings=None):
+    # If nested within an existing @given
+    if context := _current_build_context.value:
+        while True:
+            if condition(s := context.data.draw(definition)):
+                return s
+
+    # If top-level
     settings = settings or Settings.default
     return minimal(
         definition,
@@ -83,8 +98,7 @@ def find_any(definition, condition=lambda _: True, settings=None):
 
 def assert_no_examples(strategy, condition=lambda _: True):
     try:
-        result = find_any(strategy, condition)
-        raise AssertionError(f"Expected no results but found {result!r}")
+        assert_all_examples(strategy, lambda val: not condition(val))
     except (Unsatisfiable, NoSuchExample):
         pass
 
@@ -95,14 +109,21 @@ def assert_all_examples(strategy, predicate, settings=None):
     :param strategy: Hypothesis strategy to check
     :param predicate: (callable) Predicate that takes example and returns bool
     """
+    if context := _current_build_context.value:
+        for _ in range(20):
+            s = context.data.draw(strategy)
+            msg = f"Found {s!r} using strategy {strategy} which does not match"
+            assert predicate(s), msg
+
+    else:
 
-    @given(strategy)
-    @Settings(parent=settings, database=None)
-    def assert_examples(s):
-        msg = f"Found {s!r} using strategy {strategy} which does not match"
-        assert predicate(s), msg
+        @given(strategy)
+        @Settings(parent=settings, database=None)
+        def assert_examples(s):
+            msg = f"Found {s!r} using strategy {strategy} which does not match"
+            assert predicate(s), msg
 
-    assert_examples()
+        assert_examples()
 
 
 def assert_simple_property(strategy, predicate, settings=None):

hypothesis-python/tests/cover/test_datetimes.py

@@ -12,7 +12,7 @@
 
 import pytest
 
-from hypothesis import given, settings
+from hypothesis import HealthCheck, given, settings
 from hypothesis.strategies import dates, datetimes, timedeltas, times
 
 from tests.common.debug import assert_simple_property, find_any, minimal
@@ -49,6 +49,7 @@ def test_max_value_is_respected():
     assert minimal(timedeltas(max_value=dt.timedelta(days=-10))).days == -10
 
 
+@settings(suppress_health_check=list(HealthCheck))
 @given(timedeltas())
 def test_single_timedelta(val):
     assert_simple_property(timedeltas(val, val), lambda v: v is val)

hypothesis-python/tests/cover/test_slices.py

@@ -10,7 +10,7 @@
 
 import pytest
 
-from hypothesis import given, settings, strategies as st
+from hypothesis import HealthCheck, given, settings, strategies as st
 
 from tests.common.debug import assert_all_examples, find_any, minimal
 
@@ -63,9 +63,9 @@ def test_slices_will_shrink(size):
 
 
 @given(st.integers(1, 1000))
-@settings(deadline=None)
+@settings(deadline=None, suppress_health_check=list(HealthCheck))
 def test_step_will_be_negative(size):
-    find_any(st.slices(size), lambda x: (x.step or 1) < 0, settings(max_examples=10**6))
+    find_any(st.slices(size), lambda x: (x.step or 1) < 0)
 
 
 @given(st.integers(1, 1000))

hypothesis-python/tests/numpy/test_gen_data.py

@@ -17,6 +17,7 @@
 
 from hypothesis import (
     HealthCheck,
+    Phase,
     assume,
     given,
     note,
@@ -968,7 +969,7 @@ def test_mutually_broadcastable_shapes_can_generate_arbitrary_ndims(
     )
 
 
-@settings(deadline=None)
+@settings(deadline=None, suppress_health_check=list(HealthCheck))
 @given(
     base_shape=nps.array_shapes(min_dims=0, max_dims=3, min_side=0, max_side=2),
     max_dims=st.integers(1, 4),
@@ -1102,10 +1103,10 @@ def index_selects_values_in_order(index):
         target(float(np.sum(target_array == selected)), label="elements correct")
         return np.all(target_array == selected)
 
-    find_any(
+    minimal(
         nps.integer_array_indices(shape, result_shape=st.just(target_array.shape)),
         index_selects_values_in_order,
-        settings(max_examples=10**6),
+        settings(max_examples=10**6, phases=[Phase.generate, Phase.target]),
     )
 
 

hypothesis-python/tests/numpy/test_gufunc.py

@@ -12,7 +12,7 @@
 import pytest
 from pytest import param
 
-from hypothesis import example, given, note, settings, strategies as st
+from hypothesis import HealthCheck, example, given, note, settings, strategies as st
 from hypothesis.extra import numpy as nps
 from hypothesis.extra._array_helpers import _hypothesis_parse_gufunc_signature
 
@@ -66,7 +66,7 @@ def test_matmul_gufunc_shapes(everything):
     assert out.shape == result_shape
 
 
-@settings(deadline=None, max_examples=10)
+@settings(deadline=None, max_examples=10, suppress_health_check=list(HealthCheck))
 @pytest.mark.parametrize(
     "target_sig",
     ("(i),(i)->()", "(m,n),(n,p)->(m,p)", "(n),(n,p)->(p)", "(m,n),(n)->(m)"),
@@ -83,7 +83,6 @@ def test_matmul_signature_can_exercise_all_combination_of_optional_dims(
             signature="(m?,n),(n,p?)->(m?,p?)", max_dims=0
         ),
         lambda shapes: shapes == target_shapes,
-        settings(max_examples=10**6),
     )