Skip crosshair-incompatible tests

Author: Zac-HD

hypothesis-python/tests/conjecture/common.py

@@ -14,9 +14,10 @@
 from random import Random
 from typing import Optional
 
+import pytest
+
 from hypothesis import HealthCheck, Phase, assume, settings, strategies as st
-from hypothesis.control import current_build_context
-from hypothesis.errors import InvalidArgument
+from hypothesis.control import current_build_context, currently_in_test_context
 from hypothesis.internal.conjecture import engine as engine_module
 from hypothesis.internal.conjecture.choice import ChoiceNode, ChoiceT
 from hypothesis.internal.conjecture.data import ConjectureData, Status
@@ -103,10 +104,21 @@ def accept(f):
 
 
 def fresh_data(*, random=None, observer=None) -> ConjectureData:
+    context = current_build_context() if currently_in_test_context() else None
+    if context is not None and settings().backend == "crosshair":
+        # we should reeaxmine fresh_data sometime and see if we can replace it
+        # with nicer and higher level hypothesis idioms.
+        #
+        # For now it doesn't work well with crosshair tests. This is no big
+        # loss, because these tests often rely on hypothesis-provider-specific
+        # things.
+        pytest.skip(
+            "Fresh data is too low level (and too much of a hack) to be "
+            "worth supporting when testing with crosshair"
+        )
+
     if random is None:
-        try:
-            context = current_build_context()
-        except InvalidArgument:
+        if context is None:
             # ensure usage of fresh_data() is not flaky outside of property tests.
             raise ValueError(
                 "must pass a seeded Random instance to fresh_data() when "

hypothesis-python/tests/nocover/test_database_agreement.py

@@ -12,7 +12,9 @@
 import shutil
 import tempfile
 
-from hypothesis import strategies as st
+import pytest
+
+from hypothesis import settings, strategies as st
 from hypothesis.database import (
     BackgroundWriteDatabase,
     DirectoryBasedExampleDatabase,
@@ -28,7 +30,6 @@ def __init__(self):
         exampledir = os.path.join(self.tempd, "examples")
 
         self.dbs = [
-            DirectoryBasedExampleDatabase(exampledir),
             InMemoryExampleDatabase(),
             DirectoryBasedExampleDatabase(exampledir),
             BackgroundWriteDatabase(InMemoryExampleDatabase()),
@@ -75,4 +76,6 @@ def teardown(self):
         shutil.rmtree(self.tempd)
 
 
-TestDBs = DatabaseComparison.TestCase
+@pytest.mark.skipif(settings._current_profile == "crosshair", reason="isn't threadsafe")
+def test_database_equivalence():
+    DatabaseComparison.TestCase().runTest()

hypothesis-python/tests/nocover/test_precise_shrinking.py

@@ -59,6 +59,11 @@
 
 T = TypeVar("T")
 
+pytestmark = pytest.mark.skipif(
+    settings._current_profile == "crosshair",
+    reason="using internals for testing in a way crosshair doesn't support",
+)
+
 
 def safe_draw(data, strategy):
     """Set up just enough of the Hypothesis machinery to use draw on

hypothesis-python/tests/nocover/test_randomization.py

@@ -8,13 +8,14 @@
 # v. 2.0. If a copy of the MPL was not distributed with this file, You can
 # obtain one at https://mozilla.org/MPL/2.0/.
 
+from random import Random
+
 import pytest
 
 from hypothesis import (
     HealthCheck,
     Verbosity,
     core,
-    find,
     given,
     settings,
     strategies as st,
@@ -23,13 +24,30 @@
 from tests.common.utils import Why, no_shrink, xfail_on_crosshair
 
 
+@pytest.mark.skipif(
+    settings._current_profile == "crosshair",
+    reason="we do not yet pass backends the global random seed, so they are not deterministic",
+)
 def test_seeds_off_internal_random():
-    s = settings(phases=no_shrink, database=None)
-    r = core._hypothesis_global_random.getstate()
-    x = find(st.integers(), lambda x: True, settings=s)
-    core._hypothesis_global_random.setstate(r)
-    y = find(st.integers(), lambda x: True, settings=s)
-    assert x == y
+    choices1 = []
+    choices2 = []
+
+    @given(st.integers())
+    def f1(n):
+        choices1.append(n)
+
+    @given(st.integers())
+    def f2(n):
+        choices2.append(n)
+
+    core._hypothesis_global_random = Random(0)
+    state = core._hypothesis_global_random.getstate()
+    f1()
+
+    core._hypothesis_global_random.setstate(state)
+    f2()
+
+    assert choices1 == choices2
 
 
 @xfail_on_crosshair(Why.nested_given)

hypothesis-python/tests/nocover/test_stateful.py

@@ -23,6 +23,8 @@
     run_state_machine_as_test,
 )
 
+from tests.common.utils import Why
+
 
 def run_to_notes(TestClass):
     TestCase = TestClass.TestCase
@@ -204,6 +206,10 @@ def snake(self):
     "machine", bad_machines, ids=[t.__name__ for t in bad_machines]
 )
 def test_bad_machines_fail(machine):
+    if machine is CanSwarm and Settings._current_profile == "crosshair":
+        # and also takes 10 minutes, on top of not finding the failure
+        pytest.xfail(reason=str(Why.undiscovered))
+
     test_class = machine.TestCase
     try:
         test_class().runTest()