make_strategies_namespace() repr omits api_version when inferred

Author: honno

hypothesis-python/src/hypothesis/extra/array_api.py

@@ -898,12 +898,6 @@ def make_strategies_namespace(
         "you're using the latest version of Hypothesis, then open an issue if "
         "one doesn't already exist."
     )
-    check_argument(
-        api_version is None
-        or (isinstance(api_version, str) and api_version in NOMINAL_VERSIONS),
-        f"{api_version=}, but api_version must be None, or a valid version "
-        f"string {RELEASED_VERSIONS}. {not_available_msg}",
-    )
     if api_version is None:
         check_argument(
             hasattr(xp, "__array_api_version__"),
@@ -919,6 +913,14 @@ def make_strategies_namespace(
             f"be a valid version string {RELEASED_VERSIONS}. {not_available_msg}",
         )
         api_version = xp.__array_api_version__
+        inferred_version = True
+    else:
+        check_argument(
+            isinstance(api_version, str) and api_version in NOMINAL_VERSIONS,
+            f"{api_version=}, but api_version must be None, or a valid version "
+            f"string {RELEASED_VERSIONS}. {not_available_msg}",
+        )
+        inferred_version = False
     try:
         array = xp.zeros(1)
         array.__array_namespace__()
@@ -1037,10 +1039,10 @@ def complex_dtypes(self):
                 ) from e
 
         def __repr__(self):
-            return (
-                f"make_strategies_namespace("
-                f"{self.name}, api_version='{self.api_version}')"
-            )
+            f_args = self.name
+            if not inferred_version:
+                f_args += f", api_version='{self.api_version}'"
+            return f"make_strategies_namespace({f_args})"
 
     kwargs = dict(
         name=xp.__name__,

hypothesis-python/tests/array_api/test_pretty.py

@@ -12,6 +12,9 @@
 
 import pytest
 
+from hypothesis.errors import InvalidArgument
+from hypothesis.extra.array_api import make_strategies_namespace
+
 from tests.array_api.common import MIN_VER_FOR_COMPLEX
 
 
@@ -80,10 +83,22 @@ def test_namespaced_strategies_repr(xp, xps, name, valid_args):
     assert xp.__name__ not in repr(strat), f"{xp.__name__} in strat repr"
 
 
-def test_strategies_namespace_repr(xp, xps):
-    """Strategies namespace has good repr."""
-    expected = (
-        f"make_strategies_namespace({xp.__name__}, api_version='{xps.api_version}')"
-    )
+@pytest.mark.filterwarnings("ignore::hypothesis.errors.HypothesisWarning")
+def test_inferred_version_strategies_namespace_repr(xp):
+    """Strategies namespace has good repr when api_version=None."""
+    try:
+        xps = make_strategies_namespace(xp)
+    except InvalidArgument as e:
+        pytest.skip(str(e))
+    expected = f"make_strategies_namespace({xp.__name__})"
+    assert repr(xps) == expected
+    assert str(xps) == expected
+
+
+@pytest.mark.filterwarnings("ignore::hypothesis.errors.HypothesisWarning")
+def test_specified_version_strategies_namespace_repr(xp):
+    """Strategies namespace has good repr when api_version is specified."""
+    xps = make_strategies_namespace(xp, api_version="2021.12")
+    expected = f"make_strategies_namespace({xp.__name__}, api_version='2021.12')"
     assert repr(xps) == expected
     assert str(xps) == expected