PR comments:

- use new hpw;
- remove setting names for anonymous functions for old hpw; 
- remove unnecessary parentheses;
- refactor constructing current date string.

Author: shhavel

Exercises/1-closure.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const coffee = (volume, strength) =>
-  (`Coffee volume: ${volume}ml, strength: ${strength}`);
+  `Coffee volume: ${volume}ml, strength: ${strength}`;
 
 const defineCoffeeType = volume => strength => coffee(volume, strength);
 
@@ -12,14 +12,4 @@ const defineCoffeeType = volume => strength => coffee(volume, strength);
 const espresso = null;
 const americano = null;
 
-// Set names for anonymous functions (for tests).
-if (typeof espresso === 'function') {
-  Object.defineProperty(espresso, 'name',
-    { value: 'espresso', configurable: true });
-}
-if (typeof americano === 'function') {
-  Object.defineProperty(americano, 'name',
-    { value: 'americano', configurable: true });
-}
-
 module.exports = { espresso, americano };

Exercises/1-closure.test

@@ -1,4 +1,4 @@
-([{
+[{
   name: 'espresso',
   length: [30, 70],
   cases: [
@@ -13,4 +13,4 @@
     ['medium', 'Coffee volume: 150ml, strength: medium'],
     ['strong', 'Coffee volume: 150ml, strength: strong'],
   ]
-}])
+}]

Exercises/2-lambda.test

@@ -3,11 +3,8 @@
   length: [150, 400],
   test: tagDate => {
     {
-      const today = new Date();
-      const dd = String(today.getDate()).padStart(2, '0');
-      const mm = String(today.getMonth() + 1).padStart(2, '0');
-      const yyyy = today.getFullYear();
-      const expected = `[${yyyy}-${mm}-${dd}] Test`;
+      const date = new Date().toISOString().substring(0, 10);
+      const expected = `[${date}] Test`;
       const y = tagDate('Test');
       if (y !== expected) {
         throw new Error(`tagDate('Test') === ${y} expected: ${expected}`);

Exercises/3-bind.js

@@ -22,14 +22,4 @@ const H = (exp, ...args) => {
 const average = null;
 const rootMeanSquare = null;
 
-// Set names for anonymous functions (for tests).
-if (typeof average === 'function') {
-  Object.defineProperty(average, 'name',
-    { value: 'average', configurable: true });
-}
-if (typeof rootMeanSquare === 'function') {
-  Object.defineProperty(rootMeanSquare, 'name',
-    { value: 'rootMeanSquare', configurable: true });
-}
-
 module.exports = { average, rootMeanSquare };

Exercises/4-curry.js

@@ -2,7 +2,7 @@
 
 // Check 4 digit pin.
 const checkPin = (...code) =>
-  (code.join('') === '4967');
+  code.join('') === '4967';
 
 // Define function curry that accepts the length of the function
 // (amount of function arguments) and the function.
@@ -13,9 +13,4 @@ const curry = (length, fn) => (...args) => null;
 // Usage: press('3')('4')('5')('6')
 const press = curry(4, checkPin);
 
-// Set name for anonymous function (for tests).
-if (typeof press === 'function') {
-  Object.defineProperty(press, 'name', { value: 'press', configurable: true });
-}
-
 module.exports = { press };

Exercises/5-chaining.js

@@ -2,7 +2,7 @@
 
 // Check 4 digit pin.
 const checkPin = (ch1, ch2, ch3, ch4) =>
-  ([ch1, ch2, ch3, ch4].join('') === '4967');
+  [ch1, ch2, ch3, ch4].join('') === '4967';
 
 // Impement function press
 // that allows to enter pin code by one character,

package-lock.json

@@ -9,6 +9,6 @@
   },
   "dependencies": {
     "eslint": "^6.6.0",
-    "hpw": "^0.1.9"
+    "hpw": "^0.1.11"
   }
 }