Skip to content

Commit 6996be4

Browse files
tshemsedinovtshemsedinov
committed
Improve code style: constants
1 parent c6e577f commit 6996be4

File tree

15 files changed

+57
-29
lines changed

15 files changed

+57
-29
lines changed

‎basic-classic/server.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@
22

33
const http = require('node:http');
44

5-
const hostname = '127.0.0.1';
6-
const port = 8000;
5+
const HOST = '127.0.0.1';
6+
const PORT = 8000;
77

88
const server = http.createServer((req, res) => {
99
res.statusCode = 200;
1010
res.setHeader('Content-Type', 'text/plain');
1111
res.end('Hello World\n');
1212
});
1313

14-
server.listen(port, hostname, () => {
15-
console.log(`Server running at http://${hostname}:${port}/`);
14+
server.listen(PORT, HOST, () => {
15+
console.log(`Server running at http://${HOST}:${PORT}/`);
1616
});
1717

1818
server.on('error', (err) => {
1919
if (err.code === 'EACCES') {
20-
console.log(`No access to port: ${port}`);
20+
console.log(`No access to port: ${PORT}`);
2121
}
2222
});

‎basic-http/server.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
const http = require('node:http');
44

5+
const PORT = 8000;
6+
57
const user = {
68
name: 'Marcus Aurelius',
79
city: 'Rome',
@@ -21,4 +23,4 @@ server.on('clientError', (err, socket) => {
2123
socket.end('HTTP/1.1 400 Bad Request\r\n\r\n');
2224
});
2325

24-
server.listen(8000);
26+
server.listen(PORT);

‎express-cluster/server.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ const cluster = require('node:cluster');
55
const express = require('express');
66
const app = express();
77

8+
const PORT = 8000;
9+
810
const user = { name: 'jura', age: 22 };
911

1012
if (cluster.isPrimary) {
@@ -27,5 +29,5 @@ if (cluster.isPrimary) {
2729
res.end(user.age + '');
2830
});
2931

30-
app.listen(8000);
32+
app.listen(PORT);
3133
}

‎express-simple/server.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const express = require('express');
44
const app = express();
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
app.get('/', (req, res) => {
@@ -21,4 +23,4 @@ app.get('/user/age', (req, res) => {
2123
res.end(user.age.toString());
2224
});
2325

24-
app.listen(8000);
26+
app.listen(PORT);

‎http2-ws/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ const fs = require('node:fs');
44
const http2 = require('node:http2');
55
const WebSocket = require('ws');
66

7+
const PORT = 8000;
8+
79
const index = fs.readFileSync('./index.html', 'utf8');
810
const user = { name: 'jura', age: 22 };
911

@@ -43,8 +45,8 @@ const server = http2.createSecureServer(options, (req, res) => {
4345
res.end(result);
4446
});
4547

46-
server.listen(8000);
47-
console.log('Open: https://127.0.0.1:8000');
48+
server.listen(PORT);
49+
console.log(`Open: https://127.0.0.1:${PORT}`);
4850

4951
const ws = new WebSocket.Server({ server });
5052

‎ip-sticky/server.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ const http = require('node:http');
66
const cluster = require('node:cluster');
77
const cpus = os.cpus().length;
88

9+
const PORT = 2000;
10+
911
if (cluster.isPrimary) {
1012
console.log(`Master pid: ${process.pid}`);
1113
console.log(`Starting ${cpus} forks`);
@@ -28,7 +30,7 @@ if (cluster.isPrimary) {
2830
};
2931

3032
const server = new net.Server({ pauseOnConnect: true }, balancer);
31-
server.listen(2000);
33+
server.listen(PORT);
3234
} else {
3335
console.log(`Worker pid: ${process.pid}`);
3436

‎native-advanced/server.js

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
const http = require('node:http');
44

55
const PORT = 8000;
6+
67
const user = { name: 'jura', age: 22 };
78

89
const routing = {

‎native-async/server.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
const http = require('node:http');
44

5+
const PORT = 8000;
6+
const HANDLER_LENGTH = 3;
7+
58
const user = { name: 'jura', age: 22 };
69

710
const routing = {
@@ -25,7 +28,7 @@ const types = {
2528
object: ([data], callback) => callback(JSON.stringify(data)),
2629
undefined: (args, callback) => callback('not found'),
2730
function: ([fn, req, res], callback) => {
28-
if (fn.length === 3) fn(req, res, callback);
31+
if (fn.length === HANDLER_LENGTH) fn(req, res, callback);
2932
else callback(JSON.stringify(fn(req, res)));
3033
},
3134
};
@@ -40,6 +43,6 @@ const serve = (data, req, res) => {
4043
http.createServer((req, res) => {
4144
const data = routing[req.url];
4245
serve(data, req, res);
43-
}).listen(8000);
46+
}).listen(PORT);
4447

4548
setInterval(() => user.age++, 2000);

‎native-http2-alpn/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const fs = require('node:fs');
44
const http2 = require('node:http2');
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
const routing = {
@@ -44,7 +46,7 @@ const server = http2.createSecureServer(options, (req, res) => {
4446
res.end(result);
4547
});
4648

47-
server.listen(8000);
48-
console.log('Open: https://127.0.0.1:8000');
49+
server.listen(PORT);
50+
console.log(`Open: https://127.0.0.1:${PORT}`);
4951

5052
setInterval(() => user.age++, 2000);

‎native-http2-compat/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const fs = require('node:fs');
44
const http2 = require('node:http2');
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
const routing = {
@@ -41,7 +43,7 @@ const server = http2.createSecureServer(options, (req, res) => {
4143
res.end(result);
4244
});
4345

44-
server.listen(8000);
45-
console.log('Open: https://127.0.0.1:8000');
46+
server.listen(PORT);
47+
console.log(`Open: https://127.0.0.1:${PORT}`);
4648

4749
setInterval(() => user.age++, 2000);

‎native-http2/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const fs = require('node:fs');
44
const http2 = require('node:http2');
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
const routing = {
@@ -48,7 +50,7 @@ server.on('stream', (stream, headers) => {
4850
stream.end(result);
4951
});
5052

51-
server.listen(8000);
52-
console.log('Open: https://127.0.0.1:8000');
53+
server.listen(PORT);
54+
console.log(`Open: https://127.0.0.1:${PORT}`);
5355

5456
setInterval(() => user.age++, 2000);

‎native-https/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const fs = require('node:fs');
44
const https = require('node:https');
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
const routing = {
@@ -41,7 +43,7 @@ const server = https.createServer(options, (req, res) => {
4143
res.end(result);
4244
});
4345

44-
server.listen(8000);
45-
console.log('Open: https://127.0.0.1:8000');
46+
server.listen(PORT);
47+
console.log(`Open: https://127.0.0.1:${PORT}`);
4648

4749
setInterval(() => user.age++, 2000);

‎native-multidomain/server.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
const fs = require('node:fs');
44
const https = require('node:https');
55

6+
const PORT = 8000;
7+
68
const user = { name: 'jura', age: 22 };
79

810
const routing = {
@@ -62,9 +64,9 @@ const server = https.createServer(options, (req, res) => {
6264
server.addContext('*', creds);
6365
}
6466

65-
server.listen(8000);
66-
console.log('Open: https://127.0.0.1:8000');
67-
console.log(' or https://localhost:8000');
67+
server.listen(PORT);
68+
console.log(`Open: https://127.0.0.1:${PORT}`);
69+
console.log(` or https://localhost:${PORT}`);
6870

6971
console.log({ 'server._contexts': server._contexts });
7072

‎native-simple/server.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
const http = require('node:http');
44

5+
const PORT = 8000;
6+
57
const user = { name: 'jura', age: 22 };
68

79
const routing = {
@@ -34,11 +36,11 @@ http.createServer((req, res) => {
3436
const serializer = types[type];
3537
const result = serializer(data, req, res);
3638
res.end(result);
37-
}).listen(8000);
39+
}).listen(PORT);
3840

3941
// http.createServer((req, res) => {
4042
// const data = routing[req.url];
4143
// res.end(types[typeof data](data, req, res));
42-
// }).listen(8000);
44+
// }).listen(PORT);
4345

4446
setInterval(() => user.age++, 2000);

‎native-sni/server.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ const fs = require('node:fs');
44
const https = require('node:https');
55
const tls = require('node:tls');
66

7+
const PORT = 8000;
8+
79
const user = { name: 'jura', age: 22 };
810

911
const routing = {
@@ -56,8 +58,8 @@ const server = https.createServer(options, (req, res) => {
5658
});
5759

5860

59-
server.listen(8000);
60-
console.log('Open: https://127.0.0.1:8000');
61-
console.log(' or https://localhost:8000');
61+
server.listen(PORT);
62+
console.log(`Open: https://127.0.0.1:${PORT}`);
63+
console.log(` or https://localhost:${PORT}`);
6264

6365
setInterval(() => user.age++, 2000);

0 commit comments

Comments
 (0)